Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing another iOS app extension unsafe API usage in react native #13328

Closed
wants to merge 9 commits into from
Closed

Conversation

shrutic
Copy link
Contributor

@shrutic shrutic commented Apr 5, 2017

Thanks for submitting a PR! Please read these instructions carefully:

  • [yes] Explain the motivation for making this change.
    Using react-native library inside iOS app extension causes a compile error inside react native stating that usage of UIAlertView is not allowed inside iOS app extension and should use UIAlertController instead. I have updated the code to use UIAlertController based on the other instances of the UIAlertController usage in the react-native library

  • [ partial ] Provide a test plan demonstrating that the code is solid.
    This code should be launched when developers start the profiler from the React native debug menu. I am currently in process of upgrading my app from 0.34 to the latest react native ( aka app not in working state). Would appreciate if there is an alternative way for me to test this functionality out.

Just tried to create a new react-native project using "react-native init testproject" and upon running "react-native run-ios", I hit the following error and hence I could not test the debug menu Performance profiler alert.
image

  • [ yes ] Match the code formatting of the rest of the codebase.
  • [ yes ] Target the master branch, NOT a "stable" branch.

Motivation (required)

What existing problem does the pull request solve?

Test Plan (required)

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.

If you have added code that should be tested, add tests.

Next Steps

Sign the CLA, if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 5, 2017
@shrutic shrutic changed the title Fixing another iOS app unsafe API usage in react native Fixing another iOS app extension unsafe API usage in react native Apr 5, 2017
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Apr 6, 2017
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

thotegowda pushed a commit to thotegowda/react-native that referenced this pull request May 7, 2017
Summary:
Thanks for submitting a PR! Please read these instructions carefully:

- [yes] Explain the **motivation** for making this change.
    Using react-native library inside iOS app extension causes a compile error inside react native stating that usage of UIAlertView is not allowed inside iOS app extension and should use UIAlertController instead. I have updated the code to use UIAlertController based on the other instances of the UIAlertController usage in the react-native library

- [ partial ] Provide a **test plan** demonstrating that the code is solid.
This code should be launched when developers start the profiler from the React native debug menu. I am currently in process of upgrading my app from 0.34 to the latest react native ( aka app not in working state). Would appreciate if there is an alternative way for me to test this functionality out.

Just tried to create a new react-native project using "react-native init testproject" and upon running "react-native run-ios", I  hit the following error a
Closes facebook#13328

Differential Revision: D4844559

Pulled By: javache

fbshipit-source-id: e516ca57cb2abf2b09aa53abecb0fe60a40190b4
@shrutic shrutic mentioned this pull request May 19, 2017
@danny-does-stuff
Copy link

@shrutic Do you have any update on the status of this and your other related merge requests? (#14263 and #13227) I would really like to use react-native in an iMessage application but these issues make it impossible :(

@shrutic
Copy link
Contributor Author

shrutic commented Mar 14, 2019 via email

@shrutic
Copy link
Contributor Author

shrutic commented Mar 14, 2019 via email

@danny-does-stuff
Copy link

What changes did you need to make to your fork in order to get it to work?

@shrutic
Copy link
Contributor Author

shrutic commented Mar 14, 2019 via email

@danny-does-stuff
Copy link

Great, thank you for your help @shrutic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants