Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard app crash (Caused by: java.lang.NoSuchFieldError: no "Lcom/facebook/jni/HybridData) #12994

Closed
jjdp opened this issue Mar 17, 2017 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jjdp
Copy link

jjdp commented Mar 17, 2017

Description

I am getting a fatal exception when i use proguard on my release build.
Caused by: java.lang.NoSuchFieldError: no "Lcom/facebook/jni/HybridData;" field "mHybridData" in class "Lcom/facebook/react/cxxbridge/CatalystInstanceImpl;" or its superclasses

Here is the stacktrace:

03-17 07:06:58.852  1057  1432 I ActivityManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=com.myApp.staging/com.myApp.MainActivity (has extras)} from uid 10008 on display 0
03-17 07:06:58.867  1057  1451 I ActivityManager: Start proc 2234:com.myApp.staging/u0a62 for activity com.myApp.staging/com.myApp.MainActivity
03-17 07:06:58.892  2234  2234 D FirebaseApp: com.google.firebase.auth.FirebaseAuth is not linked. Skipping initialization.
03-17 07:06:58.894  2234  2234 W InstanceID/Rpc: Failed to resolve REGISTER intent, falling back
03-17 07:06:58.895  2234  2234 W InstanceID/Rpc: Both Google Play Services and legacy GSF package are missing
03-17 07:06:58.896  2234  2234 W GooglePlayServicesUtil: Google Play Store is missing.
03-17 07:06:58.896  2234  2234 I DynamiteModule: Considering local module com.google.android.gms.flags:2 and remote module com.google.android.gms.flags:0
03-17 07:06:58.896  2234  2234 I DynamiteModule: Selected local version of com.google.android.gms.flags
03-17 07:06:58.897  2234  2234 W DynamiteModule: Local module descriptor class for com.google.android.gms.crash not found.
03-17 07:06:58.897  2234  2234 W GooglePlayServicesUtil: Google Play Store is missing.
03-17 07:06:58.897  2234  2234 I DynamiteModule: Considering local module com.google.android.gms.crash:0 and remote module com.google.android.gms.crash:0
03-17 07:06:58.897  2234  2234 E FirebaseCrash: Failed to initialize crash reporting: com.google.android.gms.d.bk$a: No acceptable module found. Local version is 0 and remote version is 0.
03-17 07:06:58.897  2234  2234 D FirebaseCrash: Cannot register Firebase Analytics listener since Firebase Crash Reporting is not enabled
03-17 07:06:58.902  2234  2234 I FA      : App measurement is starting up, version: 9877
03-17 07:06:58.902  2234  2234 I FA      : To enable debug logging run: adb shell setprop log.tag.FA VERBOSE
03-17 07:06:58.905  2234  2234 I FA      : To enable faster debug mode event logging run:
03-17 07:06:58.905  2234  2234 I FA      :   adb shell setprop firebase.analytics.debug-mode com.myApp.staging
03-17 07:06:58.908  2234  2234 I FirebaseInitProvider: FirebaseApp initialization successful
03-17 07:06:58.920  2234  2234 V fb-UnpackingSoSource: locked dso store /data/user/0/com.myApp.staging/lib-main
03-17 07:06:58.921  2234  2234 I fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/com.myApp.staging/lib-main
03-17 07:06:58.921  2234  2234 V fb-UnpackingSoSource: releasing dso store lock for /data/user/0/com.myApp.staging/lib-main
03-17 07:06:58.941  2234  2234 D ReactNative: [CodePush] Loading JS bundle from "assets://index.android.bundle"
03-17 07:06:58.957  2234  2234 I art     : Thread[1,tid=2234,Native,Thread*=0xf3e34a00,peer=0x73a04258,"main"] recursive attempt to load library "/data/app/com.myApp.staging-1/lib/x86/libfb.so"
03-17 07:06:58.967  2234  2262 D OpenGLRenderer: Use EGL_SWAP_BEHAVIOR_PRESERVED: true
03-17 07:06:58.977  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.ARTGroupViewManager
03-17 07:06:58.982  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.a
03-17 07:06:58.987  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.ARTShapeViewManager
03-17 07:06:58.987  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.b
03-17 07:06:58.993  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.ARTTextViewManager
03-17 07:06:58.996  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.e
03-17 07:06:58.998  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.ARTSurfaceViewManager
03-17 07:06:59.000  2234  2234 D         : HostConnection::get() New Host Connection established 0xed716b90, tid 2234
03-17 07:06:59.000  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.art.d
03-17 07:06:59.003  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.picker.ReactDialogPickerManager
03-17 07:06:59.004  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.uimanager.g
03-17 07:06:59.004  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.drawer.ReactDrawerLayoutManager
03-17 07:06:59.005  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.picker.ReactDropdownPickerManager
03-17 07:06:59.005  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.scroll.ReactHorizontalScrollViewManager
03-17 07:06:59.006  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.image.ReactImageManager
03-17 07:06:59.007  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.modal.ReactModalHostManager
03-17 07:06:59.009  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.modal.b
03-17 07:06:59.009  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.progressbar.ReactProgressBarViewManager
03-17 07:06:59.010  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.progressbar.b
03-17 07:06:59.010  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.text.ReactRawTextManager
03-17 07:06:59.012  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.text.g
03-17 07:06:59.013  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.scroll.ReactScrollViewManager
03-17 07:06:59.013  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.slider.ReactSliderManager
03-17 07:06:59.014  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.slider.ReactSliderManager$a
03-17 07:06:59.014  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.switchview.ReactSwitchManager
03-17 07:06:59.016  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.switchview.ReactSwitchManager$a
03-17 07:06:59.016  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.text.frescosupport.FrescoBasedReactTextInlineImageViewManager
03-17 07:06:59.017  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.text.frescosupport.a
03-17 07:06:59.018  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.textinput.ReactTextInputManager
03-17 07:06:59.020  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.textinput.j
03-17 07:06:59.022  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.text.ReactTextViewManager
03-17 07:06:59.023  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.toolbar.ReactToolbarManager
03-17 07:06:59.024  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.view.ReactViewManager
03-17 07:06:59.026  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.viewpager.ReactViewPagerManager
03-17 07:06:59.026  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.text.ReactVirtualTextViewManager
03-17 07:06:59.026  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.webview.ReactWebViewManager
03-17 07:06:59.027  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.react.views.swiperefresh.SwipeRefreshLayoutManager
03-17 07:06:59.031  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.reactnative.photoview.PhotoViewManager
03-17 07:06:59.032  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.react.rnspinkit.RNSpinkit
03-17 07:06:59.033  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.reactnative.androidsdk.FBLikeViewManager
03-17 07:06:59.035  1452  1571 E Surface : getSlotFromBufferLocked: unknown buffer: 0xe8e02d90
03-17 07:06:59.036  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.reactnative.androidsdk.FBLoginButtonManager
03-17 07:06:59.036  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.reactnative.androidsdk.FBSendButtonManager
03-17 07:06:59.037  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.facebook.reactnative.androidsdk.FBShareButtonManager
03-17 07:06:59.037  2234  2261 W unknown:ViewManagerPropertyUpdater: Could not find generated setter for class com.oney.WebRTCModule.RTCVideoViewManager
03-17 07:06:59.053  2234  2262 D libEGL  : loaded /system/lib/egl/libEGL_emulation.so
03-17 07:06:59.054  2234  2262 D libEGL  : loaded /system/lib/egl/libGLESv1_CM_emulation.so
03-17 07:06:59.054  2234  2261 D JVM     : JVM::Initialize@[tid=2261]
03-17 07:06:59.054  2234  2261 D JVM     : JVM::JVM@[tid=2261]
03-17 07:06:59.061  2234  2261 W AudioCapabilities: Unsupported mime audio/x-ms-wma
03-17 07:06:59.062  2234  2261 W AudioCapabilities: Unsupported mime audio/vnd.rn-realaudio
03-17 07:06:59.064  2234  2262 D libEGL  : loaded /system/lib/egl/libGLESv2_emulation.so
03-17 07:06:59.064  2234  2261 W AudioCapabilities: Unsupported mime audio/mpeg-L2
03-17 07:06:59.064  2234  2261 W AudioCapabilities: Unsupported mime audio/ac3
03-17 07:06:59.065  2234  2261 W AudioCapabilities: Unsupported mime audio/x-ape
03-17 07:06:59.066  2234  2261 W AudioCapabilities: Unsupported mime audio/vnd.dts
03-17 07:06:59.067  2234  2261 W AudioCapabilities: Unsupported mime audio/x-pcm
03-17 07:06:59.067  2234  2261 W AudioCapabilities: Unsupported mime audio/ffmpeg
03-17 07:06:59.068  2234  2262 D         : HostConnection::get() New Host Connection established 0xeebd2920, tid 2262
03-17 07:06:59.069  2234  2261 W VideoCapabilities: Unsupported mime video/x-ms-wmv
03-17 07:06:59.070  2234  2261 W VideoCapabilities: Unsupported mime video/vnd.rn-realvideo
03-17 07:06:59.071  2234  2261 W VideoCapabilities: Unsupported mime video/vc1
03-17 07:06:59.071  2234  2261 W VideoCapabilities: Unsupported mime video/x-flv
03-17 07:06:59.072  2234  2261 W VideoCapabilities: Unsupported mime video/divx
03-17 07:06:59.072  2234  2261 W VideoCapabilities: Unsupported mime video/ffmpeg
03-17 07:06:59.076  2234  2262 I OpenGLRenderer: Initialized EGL, version 1.4
03-17 07:06:59.082  2234  2261 I VideoCapabilities: Unsupported profile 4 for video/mp4v-es
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: Trying to find HW decoder for mime video/x-vnd.on2.vp8
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: Found candidate decoder OMX.google.vp8.decoder
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: No HW decoder found for mime video/x-vnd.on2.vp8
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: Trying to find HW decoder for mime video/x-vnd.on2.vp9
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: Found candidate decoder OMX.google.vp9.decoder
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: No HW decoder found for mime video/x-vnd.on2.vp9
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: Trying to find HW decoder for mime video/avc
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: Found candidate decoder OMX.ffmpeg.h264.decoder
03-17 07:06:59.083  2234  2261 I org.webrtc.Logging: MediaCodecVideoDecoder: No HW decoder found for mime video/avc
03-17 07:06:59.085  2234  2266 D JVM     : AttachCurrentThreadIfNeeded::ctor@[tid=2266]
03-17 07:06:59.085  2234  2266 D JVM     : Attaching thread to JVM
03-17 07:06:59.086  2234  2266 D JVM     : JVM::environment@[tid=2266]
03-17 07:06:59.086  2234  2266 D JVM     : JNIEnvironment::ctor@[tid=2266]
03-17 07:06:59.086  2234  2266 D AudioManager: ctor@[tid=2266]
03-17 07:06:59.086  2234  2266 D JVM     : JNIEnvironment::RegisterNatives(org/webrtc/voiceengine/WebRtcAudioManager)
03-17 07:06:59.086  2234  2266 D JVM     : NativeRegistration::ctor@[tid=2266]
03-17 07:06:59.086  2234  2266 D JVM     : NativeRegistration::NewObject@[tid=2266]
03-17 07:06:59.086  2234  2266 I org.webrtc.Logging: WebRtcAudioManager: ctor@[name=Thread-167, id=167]
03-17 07:06:59.087  2234  2266 I org.webrtc.Logging: WebRtcAudioManager: Sample rate is set to 44100 Hz
03-17 07:06:59.091  2234  2266 I org.webrtc.Logging: WebRtcAudioEffects: canUseAcousticEchoCanceler: false
03-17 07:06:59.091  2234  2266 I org.webrtc.Logging: WebRtcAudioEffects: canUseAutomaticGainControl: false
03-17 07:06:59.091  2234  2266 I org.webrtc.Logging: WebRtcAudioEffects: canUseNoiseSuppressor: false
03-17 07:06:59.093  2234  2266 D AudioManager: OnCacheAudioParameters@[tid=2266]
03-17 07:06:59.093  2234  2266 D AudioManager: hardware_aec: 0
03-17 07:06:59.093  2234  2266 D AudioManager: hardware_agc: 0
03-17 07:06:59.093  2234  2266 D AudioManager: hardware_ns: 0
03-17 07:06:59.093  2234  2266 D AudioManager: low_latency_output: 0
03-17 07:06:59.093  2234  2266 D AudioManager: pro_audio: 0
03-17 07:06:59.093  2234  2266 D AudioManager: sample_rate: 44100
03-17 07:06:59.093  2234  2266 D AudioManager: channels: 1
03-17 07:06:59.093  2234  2266 D AudioManager: output_buffer_size: 3174
03-17 07:06:59.093  2234  2266 D AudioManager: input_buffer_size: 2048
03-17 07:06:59.093  2234  2266 D JVM     : GlobalRef::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D AudioManager: JavaAudioManager::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D AudioManager: IsLowLatencyPlayoutSupported()
03-17 07:06:59.093  2234  2266 D JVM     : AttachCurrentThreadIfNeeded::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : JVM::environment@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : JNIEnvironment::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D AudioTrackJni: ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : JNIEnvironment::RegisterNatives(org/webrtc/voiceengine/WebRtcAudioTrack)
03-17 07:06:59.093  2234  2266 D JVM     : NativeRegistration::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : NativeRegistration::NewObject@[tid=2266]
03-17 07:06:59.093  2234  2266 I org.webrtc.Logging: WebRtcAudioTrack: ctor@[name=Thread-167, id=167]
03-17 07:06:59.093  2234  2266 D JVM     : GlobalRef::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : AttachCurrentThreadIfNeeded::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : JVM::environment@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : JNIEnvironment::ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D AudioRecordJni: ctor@[tid=2266]
03-17 07:06:59.093  2234  2266 D JVM     : JNIEnvironment::RegisterNatives(org/webrtc/voiceengine/WebRtcAudioRecord)
03-17 07:06:59.093  2234  2266 D JVM     : NativeRegistration::ctor@[tid=2266]
03-17 07:06:59.094  2234  2266 D JVM     : NativeRegistration::NewObject@[tid=2266]
03-17 07:06:59.094  2234  2266 I org.webrtc.Logging: WebRtcAudioRecord: ctor@[name=Thread-167, id=167]
03-17 07:06:59.094  2234  2266 I org.webrtc.Logging: WebRtcAudioEffects: ctor@[name=Thread-167, id=167]
03-17 07:06:59.094  2234  2266 D JVM     : GlobalRef::ctor@[tid=2266]
03-17 07:06:59.094  2234  2266 D AudioManager: SetActiveAudioLayer(5)@[tid=2266]
03-17 07:06:59.094  2234  2266 D AudioManager: delay_estimate_in_milliseconds: 150
03-17 07:06:59.094  2234  2266 D AudioTrackJni: AttachAudioBuffer@[tid=2266]
03-17 07:06:59.094  2234  2266 D AudioTrackJni: SetPlayoutSampleRate(44100)
03-17 07:06:59.094  2234  2266 D AudioTrackJni: SetPlayoutChannels(1)
03-17 07:06:59.094  2234  2266 D AudioRecordJni: AttachAudioBuffer
03-17 07:06:59.094  2234  2266 D AudioRecordJni: SetRecordingSampleRate(44100)
03-17 07:06:59.094  2234  2266 D AudioRecordJni: SetRecordingChannels(1)
03-17 07:06:59.094  2234  2266 D AudioRecordJni: total_delay_in_milliseconds: 150
03-17 07:06:59.094  2234  2266 D AudioManager: Init@[tid=2266]
03-17 07:06:59.094  2234  2266 I org.webrtc.Logging: WebRtcAudioManager: init@[name=Thread-167, id=167]
03-17 07:06:59.095  2234  2266 I org.webrtc.Logging: WebRtcAudioManager: audio mode is: MODE_NORMAL
03-17 07:06:59.096  2234  2266 D AudioTrackJni: Init@[tid=2266]
03-17 07:06:59.096  2234  2266 D AudioRecordJni: Init@[tid=2266]
03-17 07:06:59.102  2234  2265 I org.webrtc.Logging: PeerConnectionFactory: onNetworkThreadReady
03-17 07:06:59.103  2234  2266 I org.webrtc.Logging: PeerConnectionFactory: onWorkerThreadReady
03-17 07:06:59.105  2234  2267 I org.webrtc.Logging: PeerConnectionFactory: onSignalingThreadReady
03-17 07:06:59.106  2234  2261 D InCallManager: fallback to old school screen locker...
03-17 07:06:59.107  2234  2261 D InCallManager: InCallManager initialized
03-17 07:06:59.110  2234  2261 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #5
03-17 07:06:59.110  2234  2261 E AndroidRuntime: Process: com.myApp.staging, PID: 2234
03-17 07:06:59.110  2234  2261 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground()
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at android.os.AsyncTask$3.done(AsyncTask.java:309)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.util.concurrent.FutureTask.run(FutureTask.java:242)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.lang.Thread.run(Thread.java:818)
03-17 07:06:59.110  2234  2261 E AndroidRuntime: Caused by: java.lang.NoSuchFieldError: no "Lcom/facebook/jni/HybridData;" field "mHybridData" in class "Lcom/facebook/react/cxxbridge/CatalystInstanceImpl;" or its superclasses
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.cxxbridge.CatalystInstanceImpl.initializeBridge(Native Method)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.cxxbridge.CatalystInstanceImpl.<init>(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.cxxbridge.CatalystInstanceImpl.<init>(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.cxxbridge.CatalystInstanceImpl$b.a(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.j.a(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.j.a(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.j$a.a(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at com.facebook.react.j$a.doInBackground(Unknown Source)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at android.os.AsyncTask$2.call(AsyncTask.java:295)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
03-17 07:06:59.110  2234  2261 E AndroidRuntime:        ... 3 more
03-17 07:06:59.110  1057  1451 W ActivityManager:   Force finishing activity com.myApp.staging/com.myApp.MainActivity
03-17 07:06:59.126  2234  2262 W EGL_emulation: eglSurfaceAttrib not implemented
03-17 07:06:59.126  2234  2262 W OpenGLRenderer: Failed to set EGL_SWAP_BEHAVIOR on surface 0xeebd3e00, error=EGL_SUCCESS
03-17 07:06:59.129  1057  1451 D         : HostConnection::get() New Host Connection established 0xe8d86a80, tid 1451
03-17 07:06:59.145  2234  2249 I FA      : This instance being marked as an uploader
03-17 07:06:59.150  1080  1080 E EGL_emulation: tid 1080: eglCreateSyncKHR(1215): error 0x3004 (EGL_BAD_ATTRIBUTE)
03-17 07:06:59.191    98    98 D         : Socket deconnection
03-17 07:06:59.235  1057  2223 I OpenGLRenderer: Initialized EGL, version 1.4
03-17 07:06:59.250  1057  2223 W EGL_emulation: eglSurfaceAttrib not implemented
03-17 07:06:59.250  1057  2223 W OpenGLRenderer: Failed to set EGL_SWAP_BEHAVIOR on surface 0xdc561b20, error=EGL_SUCCESS
03-17 07:06:59.269  1452  1571 W EGL_emulation: eglSurfaceAttrib not implemented
03-17 07:06:59.269  1452  1571 W OpenGLRenderer: Failed to set EGL_SWAP_BEHAVIOR on surface 0xdf71e5a0, error=EGL_SUCCESS
03-17 07:06:59.271  2234  2262 E Surface : getSlotFromBufferLocked: unknown buffer: 0xe8e024d0
03-17 07:06:59.299  1057  1474 W ActivityManager: Unable to start service Intent { act=com.google.android.gms.ads.identifier.service.START pkg=com.google.android.gms } U=0: not found
03-17 07:06:59.353   751  1132 W AudioFlinger: write blocked for 488 msecs, 3 delayed writes, thread 0xf1e80000
03-17 07:06:59.377  1057  1483 I ActivityManager: Killing 1886:com.android.email/u0a34 (adj 15): empty #17
03-17 07:07:00.601  2234  2261 I Process : Sending signal. PID: 2234 SIG: 9
03-17 07:07:00.606  1057  1451 D GraphicsStats: Buffer count: 4
03-17 07:07:00.629  1057  1483 I ActivityManager: Process com.myApp.staging (pid 2234) has died
03-17 07:07:00.632  1057  2223 E Surface : getSlotFromBufferLocked: unknown buffer: 0xdf4db920
03-17 07:07:00.637  1057  2223 D OpenGLRenderer: endAllStagingAnimators on 0xdee4b280 (RippleDrawable) with handle 0xdc5609a0
03-17 07:07:00.639  1057  1432 W InputMethodManagerService: Got RemoteException sending setActive(false) notification to pid 2234 uid 10062
03-17 07:07:00.818  1057  1076 W AppOps  : Finishing op nesting under-run: uid 1000 pkg android code 24 time=0 duration=0 nesting=0
03-17 07:07:01.194    98    98 D         : Socket deconnection

Additional Information

  • React Native version: 0.42.0
  • Platform: Android
  • Operating System: Windows 10 x64
@jjdp
Copy link
Author

jjdp commented Mar 20, 2017

this happens when you uncomment -dontobfuscate. is there any way to have an exception for these two classes?

@jjdp
Copy link
Author

jjdp commented Mar 20, 2017

i had to add these:

-keep class com.facebook.react.cxxbridge.CatalystInstanceImpl { *; }
-keep class com.facebook.react.cxxbridge.JavaScriptExecutor { *; }
-keep class com.facebook.react.bridge.queue.NativeRunnable { *; }
-keep class com.facebook.react.bridge.ExecutorToken { *; }
-keep class com.facebook.react.bridge.ReadableType { *; }

aren't they supposed to be not obfuscated if they have @DoNotStrip in them?

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@lyahdav
Copy link
Contributor

lyahdav commented Aug 20, 2017

I believe this issue should be reopened. It's an issue that can happen when integrating React Native into an existing Android project. It will only happen if your project's Proguard rules do not include -dontobfuscate. The default Proguard rules file for React Native includes -dontobfuscate so this issue doesn't happen in a pure React Native Android project.

To reproduce:

  1. Create a new React Native project (I reproduced with version 0.47.1)
  2. In android/app/proguard-rules.pro file remove the -dontobfuscate line
  3. In android/app/build.gradle file set enableProguardInReleaseBuilds = true
  4. Follow steps here to make release APK.
  5. When you run the app, you'll get a crash with error:
java.lang.NoSuchFieldError: no "Lcom/facebook/jni/HybridData;" field "mHybridData" in class "Lcom/facebook/react/bridge/JavaScriptExecutor;" or its superclasses
                                                       at com.facebook.react.bridge.CatalystInstanceImpl.initializeBridge(Native Method)
                                                       at com.facebook.react.bridge.CatalystInstanceImpl.<init>(SourceFile:114)
                                                       at com.facebook.react.bridge.CatalystInstanceImpl.<init>(SourceFile:42)
                                                       at bnv.a(SourceFile:574)
                                                       at bmg.a(SourceFile:999)
                                                       at bmg.a(SourceFile:109)
                                                       at bmg$4.run(SourceFile:802)
                                                       at java.lang.Thread.run(Thread.java:761)

To fix, add the following to proguard-rules.pro (slightly different than @jjdp's answer for RN 0.42.0 above):

-keep class com.facebook.react.bridge.CatalystInstanceImpl { *; }
-keep class com.facebook.react.bridge.JavaScriptExecutor { *; }
-keep class com.facebook.react.bridge.queue.NativeRunnable { *; }
-keep class com.facebook.react.bridge.ReadableType { *; }

I'm not entirely sure why the -dontobfuscate makes a difference. The classes I had to keep via Proguard rules are all annotated with @DoNotStrip as @jjdp mentioned above.

There's also a Stack Overflow post about this here.

facebook-github-bot pushed a commit that referenced this issue Apr 6, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs #18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix #12994 and #6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes #18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
campsafari pushed a commit to exozet/react-native that referenced this issue Apr 11, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs facebook#18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix facebook#12994 and facebook#6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
LukeDurrant pushed a commit to LukeDurrant/react-native that referenced this issue Apr 11, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs facebook#18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix facebook#12994 and facebook#6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
LukeDurrant pushed a commit to LukeDurrant/react-native that referenced this issue Apr 11, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs facebook#18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix facebook#12994 and facebook#6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
bunnyc1986 pushed a commit to bunnyc1986/react-native that referenced this issue May 11, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs facebook#18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix facebook#12994 and facebook#6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
facebook-github-bot pushed a commit that referenced this issue Jun 16, 2018
Summary:
This sync includes the following changes:
- **[ae14317d6](facebook/react@ae14317d6)**: Inline fbjs/lib/emptyFunction (#13054) //<Dan Abramov>//
- **[72434a768](facebook/react@72434a768)**: Remove or inline some fbjs dependencies (#13046) //<Dan Abramov>//
- **[64c54edea](facebook/react@64c54edea)**: Adding movementX and movementY to synthenticMouseEvent fixes #6723 (#9018) //<Jason Williams>//
- **[9bd4d1fae](facebook/react@9bd4d1fae)**: Synchronously restart when an error is thrown during async rendering (#13041) //<Andrew Clark>//
- **[9bda7b28f](facebook/react@9bda7b28f)**: Suspended high pri work forces lower priority work to expire early  (#12965) //<Andrew Clark>//
- **[2e7577907](facebook/react@2e7577907)**: Fix incorrect data in compositionend event with Korean IME on IE11 (#10217) (#12563) //<Crux>//
- **[bc963f353](facebook/react@bc963f353)**: setJSResponder in Fabric renderer (#13031) //<Sebastian Markbåge>//
- **[051637da6](facebook/react@051637da6)**: Extract Fabric event handlers from canonical props (#13024) //<Sebastian Markbåge>//
- **[2a8085980](facebook/react@2a8085980)**: Remove rAF fork (#12980) //<Flarnie Marchan>//
- **[e0c78344e](facebook/react@e0c78344e)**: Retry on error if there's lower priority pending work (#12957) //<Andrew Clark>//
- **[9725065eb](facebook/react@9725065eb)**: Update bundle sizes for 16.4.1 release //<Dan Abramov>//
- **[0b87b2790](facebook/react@0b87b2790)**: Updating package versions for release 16.4.1 //<Dan Abramov>//
- **[036ae3c6e](facebook/react@036ae3c6e)**: Use native event dispatching instead of Simulate or SimulateNative (#13023) //<Philipp Spieß>//
- **[945fc1bfc](facebook/react@945fc1bfc)**: Call gDSFP with the right state in react-test-render (#13030) //<Rafał Ruciński>//
- **[392530104](facebook/react@392530104)**: Remove feature flag around 'getDerivedStateFromProps' bug fix (#13022) //<Flarnie Marchan>//
- **[1594409fa](facebook/react@1594409fa)**: Scheduler depends on common packages (#13020) //<Dan Abramov>//
- **[d5c11193e](facebook/react@d5c11193e)**: Added production profiling bundle type (#12886) //<Brian Vaughn>//
- **[ec60457bc](facebook/react@ec60457bc)**: Popping context is O(1) in SSR (#13019) //<Dan Abramov>//
- **[30bc8ef79](facebook/react@30bc8ef79)**: Allow multiple root children in test renderer traversal API (#13017) //<Dan Abramov>//
- **[d480782c4](facebook/react@d480782c4)**: Don’t error when returning an empty Fragment (#12966) //<Philipp Spieß>//
- **[4ac6f133a](facebook/react@4ac6f133a)**: Fallback to event.srcElement for IE9 (#12976) //<Nathan Hunzaker>//
- **[23be4102d](facebook/react@23be4102d)**: Fixed an issue with nested contexts unwinding when server rendering. Issue #12984 (#12985) //<Eric Soderberg>//
- **[d0d428064](facebook/react@d0d428064)**: Remove old reference to inst._wrapperState (#12987) //<Nathan Hunzaker>//
- **[c78957eac](facebook/react@c78957eac)**: Fix an SVG focusing crash in IE11 (#12996) //<Jifa Jiang>//
- **[bfb12ebb5](facebook/react@bfb12ebb5)**: delete a couple of redundant lines in performWorkOnRoot() in ReactFiberScheduler.js (#13003) //<Nathan Quarles>//
- **[394b17eed](facebook/react@394b17eed)**: Update custom renderer docs //<Dan Abramov>//
- **[188c4252a](facebook/react@188c4252a)**: Fix react-dom ReferenceError requestAnimationFrame in non-browser env (#13000) (#13001) //<Ivan Babak>//
- **[9cf3733a9](facebook/react@9cf3733a9)**: update comment in computeAsyncExpiration() to reflect code (#12994) //<Nathan Quarles>//
- **[c5a733e1e](facebook/react@c5a733e1e)**: Fix links of docs on the comment (#12795) //<Ende93>//
- **[36546b513](facebook/react@36546b513)**: Set the correct initial value on input range (#12939) //<Maxime Nory>//
- **[15767a8f8](facebook/react@15767a8f8)**: [scheduler] 5/n Error handling in scheduler (#12920) //<Flarnie Marchan>//
- **[3118ed9d6](facebook/react@3118ed9d6)**: Expose unstable_interactiveUpdates on ReactDOM (#12943) //<Andrew Clark>//
- **[524a74331](facebook/react@524a74331)**: Fix for Flow issues in SimpleCacheProvider (#12942) //<Flarnie Marchan>//
- **[ae57b125c](facebook/react@ae57b125c)**: [simple-cache-provider] Use LRU cache eviction (#12851) //<Andrew Clark>//
- **[e0a03c1b4](facebook/react@e0a03c1b4)**: Extend input type check in selection capabilities (#12062) (#12135) //<Spyros Ioakeimidis>//
- **[79a740c6e](facebook/react@79a740c6e)**: Rename variables to remove references to 'global' global (#12931) //<Flarnie Marchan>//
- **[ff724d3c2](facebook/react@ff724d3c2)**: [scheduler] 4/n Allow splitting out `schedule` in fb-www, prepare to fix polyfill issue internally (#12900) //<Flarnie Marchan>//
- **[83f76e4db](facebook/react@83f76e4db)**: ForwardRefs supports propTypes (#12911) //<Brian Vaughn>//
- **[8aeea5afa](facebook/react@8aeea5afa)**: Do not assign node.value on input creation if no change will occur (#12925) //<Nathan Hunzaker>//
- **[aa85b0fd5](facebook/react@aa85b0fd5)**: Upgrade to Jest 23 (#12894) //<Simen Bekkhus>//
- **[61777a78f](facebook/react@61777a78f)**: [scheduler] 3/n Use a linked list instead of map and queue for callback storage (#12893) //<Flarnie Marchan>//
- **[e7bd3d59a](facebook/react@e7bd3d59a)**: No longer expose ReactNativeComponentTree (#12904) //<Sebastian Markbåge>//
- **[f35d989be](facebook/react@f35d989be)**: TestRenderer warns if flushThrough is passed the wrong params (#12909) //<Brian Vaughn>//
- **[557870067](facebook/react@557870067)**: Record "actual" times for all Fibers within a Profiler tree (alt) (#12910) //<Brian Vaughn>//
- **[76e07071a](facebook/react@76e07071a)**: [scheduler] 2/n Adding 'schedule' fixture (#12884) //<Flarnie Marchan>//
- **[345e0a71a](facebook/react@345e0a71a)**: Improve tests for 'schedule' module (#12880) //<Flarnie Marchan>//
- **[8765d6089](facebook/react@8765d6089)**: Update bundle sizes for 16.4.0 release //<Andrew Clark>//
- **[d427a563d](facebook/react@d427a563d)**: Updating package versions for release 16.4.0 //<Andrew Clark>//
- **[53852a887](facebook/react@53852a887)**: add functional components warning about legacy context api (#12892) //<Chang Yan>//
- **[fe747a51c](facebook/react@fe747a51c)**: Add React.Timeout to getComponentName (#12890) //<Toru Kobayashi>//
- **[c601f7a64](facebook/react@c601f7a64)**: add siblings Timeout components test case (#12862) //<Chang Yan>//
- **[735035837](facebook/react@735035837)**: add legacy context API warning in strict mode (#12849) //<Chang Yan>//
- **[e88579184](facebook/react@e88579184)**: Fix a regression that caused us to listen to extra events at the top (#12878) //<Dan Abramov>//
- **[7c0aca289](facebook/react@7c0aca289)**: Rollup freeze: false (#12879) //<Brian Vaughn>//
- **[33289b530](facebook/react@33289b530)**: Tests and fixes for 'timing out' behavior (#12858) //<Flarnie Marchan>//
- **[ad27845cc](facebook/react@ad27845cc)**: Fix double-firing submit events (#12877) //<Sophie Alpert>//
- **[dd5fad296](facebook/react@dd5fad296)**: Update Flow to 0.70 (#12875) //<Dan Abramov>//
- **[13003654e](facebook/react@13003654e)**: Pass "start time" and "commit time" to Profiler callback (#12852) //<Brian Vaughn>//
- **[dc3b144f4](facebook/react@dc3b144f4)**: Treat Rollup "warnings" as errors (#12868) //<Dan Abramov>//
- **[d7b9b4921](facebook/react@d7b9b4921)**: Fix react native example links in README of 'react-reconciler' (#12871) //<Kevin (Kun) "Kassimo" Qian>//
- **[9bed4a6ae](facebook/react@9bed4a6ae)**: https in reactProdInvariant text (#12869) //<Sophie Alpert>//
- **[47b003a82](facebook/react@47b003a82)**: Resolve host configs at build time (#12792) //<Dan Abramov>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions c0fe8d6...ae14317

Reviewed By: bvaughn

Differential Revision: D8458731

fbshipit-source-id: afefaa50685d43e70c8ea85c70d2e29dee311cbb
grabbou pushed a commit that referenced this issue Jun 21, 2018
Summary:
This sync includes the following changes:
- **[ae14317d6](facebook/react@ae14317d6)**: Inline fbjs/lib/emptyFunction (#13054) //<Dan Abramov>//
- **[72434a768](facebook/react@72434a768)**: Remove or inline some fbjs dependencies (#13046) //<Dan Abramov>//
- **[64c54edea](facebook/react@64c54edea)**: Adding movementX and movementY to synthenticMouseEvent fixes #6723 (#9018) //<Jason Williams>//
- **[9bd4d1fae](facebook/react@9bd4d1fae)**: Synchronously restart when an error is thrown during async rendering (#13041) //<Andrew Clark>//
- **[9bda7b28f](facebook/react@9bda7b28f)**: Suspended high pri work forces lower priority work to expire early  (#12965) //<Andrew Clark>//
- **[2e7577907](facebook/react@2e7577907)**: Fix incorrect data in compositionend event with Korean IME on IE11 (#10217) (#12563) //<Crux>//
- **[bc963f353](facebook/react@bc963f353)**: setJSResponder in Fabric renderer (#13031) //<Sebastian Markbåge>//
- **[051637da6](facebook/react@051637da6)**: Extract Fabric event handlers from canonical props (#13024) //<Sebastian Markbåge>//
- **[2a8085980](facebook/react@2a8085980)**: Remove rAF fork (#12980) //<Flarnie Marchan>//
- **[e0c78344e](facebook/react@e0c78344e)**: Retry on error if there's lower priority pending work (#12957) //<Andrew Clark>//
- **[9725065eb](facebook/react@9725065eb)**: Update bundle sizes for 16.4.1 release //<Dan Abramov>//
- **[0b87b2790](facebook/react@0b87b2790)**: Updating package versions for release 16.4.1 //<Dan Abramov>//
- **[036ae3c6e](facebook/react@036ae3c6e)**: Use native event dispatching instead of Simulate or SimulateNative (#13023) //<Philipp Spieß>//
- **[945fc1bfc](facebook/react@945fc1bfc)**: Call gDSFP with the right state in react-test-render (#13030) //<Rafał Ruciński>//
- **[392530104](facebook/react@392530104)**: Remove feature flag around 'getDerivedStateFromProps' bug fix (#13022) //<Flarnie Marchan>//
- **[1594409fa](facebook/react@1594409fa)**: Scheduler depends on common packages (#13020) //<Dan Abramov>//
- **[d5c11193e](facebook/react@d5c11193e)**: Added production profiling bundle type (#12886) //<Brian Vaughn>//
- **[ec60457bc](facebook/react@ec60457bc)**: Popping context is O(1) in SSR (#13019) //<Dan Abramov>//
- **[30bc8ef79](facebook/react@30bc8ef79)**: Allow multiple root children in test renderer traversal API (#13017) //<Dan Abramov>//
- **[d480782c4](facebook/react@d480782c4)**: Don’t error when returning an empty Fragment (#12966) //<Philipp Spieß>//
- **[4ac6f133a](facebook/react@4ac6f133a)**: Fallback to event.srcElement for IE9 (#12976) //<Nathan Hunzaker>//
- **[23be4102d](facebook/react@23be4102d)**: Fixed an issue with nested contexts unwinding when server rendering. Issue #12984 (#12985) //<Eric Soderberg>//
- **[d0d428064](facebook/react@d0d428064)**: Remove old reference to inst._wrapperState (#12987) //<Nathan Hunzaker>//
- **[c78957eac](facebook/react@c78957eac)**: Fix an SVG focusing crash in IE11 (#12996) //<Jifa Jiang>//
- **[bfb12ebb5](facebook/react@bfb12ebb5)**: delete a couple of redundant lines in performWorkOnRoot() in ReactFiberScheduler.js (#13003) //<Nathan Quarles>//
- **[394b17eed](facebook/react@394b17eed)**: Update custom renderer docs //<Dan Abramov>//
- **[188c4252a](facebook/react@188c4252a)**: Fix react-dom ReferenceError requestAnimationFrame in non-browser env (#13000) (#13001) //<Ivan Babak>//
- **[9cf3733a9](facebook/react@9cf3733a9)**: update comment in computeAsyncExpiration() to reflect code (#12994) //<Nathan Quarles>//
- **[c5a733e1e](facebook/react@c5a733e1e)**: Fix links of docs on the comment (#12795) //<Ende93>//
- **[36546b513](facebook/react@36546b513)**: Set the correct initial value on input range (#12939) //<Maxime Nory>//
- **[15767a8f8](facebook/react@15767a8f8)**: [scheduler] 5/n Error handling in scheduler (#12920) //<Flarnie Marchan>//
- **[3118ed9d6](facebook/react@3118ed9d6)**: Expose unstable_interactiveUpdates on ReactDOM (#12943) //<Andrew Clark>//
- **[524a74331](facebook/react@524a74331)**: Fix for Flow issues in SimpleCacheProvider (#12942) //<Flarnie Marchan>//
- **[ae57b125c](facebook/react@ae57b125c)**: [simple-cache-provider] Use LRU cache eviction (#12851) //<Andrew Clark>//
- **[e0a03c1b4](facebook/react@e0a03c1b4)**: Extend input type check in selection capabilities (#12062) (#12135) //<Spyros Ioakeimidis>//
- **[79a740c6e](facebook/react@79a740c6e)**: Rename variables to remove references to 'global' global (#12931) //<Flarnie Marchan>//
- **[ff724d3c2](facebook/react@ff724d3c2)**: [scheduler] 4/n Allow splitting out `schedule` in fb-www, prepare to fix polyfill issue internally (#12900) //<Flarnie Marchan>//
- **[83f76e4db](facebook/react@83f76e4db)**: ForwardRefs supports propTypes (#12911) //<Brian Vaughn>//
- **[8aeea5afa](facebook/react@8aeea5afa)**: Do not assign node.value on input creation if no change will occur (#12925) //<Nathan Hunzaker>//
- **[aa85b0fd5](facebook/react@aa85b0fd5)**: Upgrade to Jest 23 (#12894) //<Simen Bekkhus>//
- **[61777a78f](facebook/react@61777a78f)**: [scheduler] 3/n Use a linked list instead of map and queue for callback storage (#12893) //<Flarnie Marchan>//
- **[e7bd3d59a](facebook/react@e7bd3d59a)**: No longer expose ReactNativeComponentTree (#12904) //<Sebastian Markbåge>//
- **[f35d989be](facebook/react@f35d989be)**: TestRenderer warns if flushThrough is passed the wrong params (#12909) //<Brian Vaughn>//
- **[557870067](facebook/react@557870067)**: Record "actual" times for all Fibers within a Profiler tree (alt) (#12910) //<Brian Vaughn>//
- **[76e07071a](facebook/react@76e07071a)**: [scheduler] 2/n Adding 'schedule' fixture (#12884) //<Flarnie Marchan>//
- **[345e0a71a](facebook/react@345e0a71a)**: Improve tests for 'schedule' module (#12880) //<Flarnie Marchan>//
- **[8765d6089](facebook/react@8765d6089)**: Update bundle sizes for 16.4.0 release //<Andrew Clark>//
- **[d427a563d](facebook/react@d427a563d)**: Updating package versions for release 16.4.0 //<Andrew Clark>//
- **[53852a887](facebook/react@53852a887)**: add functional components warning about legacy context api (#12892) //<Chang Yan>//
- **[fe747a51c](facebook/react@fe747a51c)**: Add React.Timeout to getComponentName (#12890) //<Toru Kobayashi>//
- **[c601f7a64](facebook/react@c601f7a64)**: add siblings Timeout components test case (#12862) //<Chang Yan>//
- **[735035837](facebook/react@735035837)**: add legacy context API warning in strict mode (#12849) //<Chang Yan>//
- **[e88579184](facebook/react@e88579184)**: Fix a regression that caused us to listen to extra events at the top (#12878) //<Dan Abramov>//
- **[7c0aca289](facebook/react@7c0aca289)**: Rollup freeze: false (#12879) //<Brian Vaughn>//
- **[33289b530](facebook/react@33289b530)**: Tests and fixes for 'timing out' behavior (#12858) //<Flarnie Marchan>//
- **[ad27845cc](facebook/react@ad27845cc)**: Fix double-firing submit events (#12877) //<Sophie Alpert>//
- **[dd5fad296](facebook/react@dd5fad296)**: Update Flow to 0.70 (#12875) //<Dan Abramov>//
- **[13003654e](facebook/react@13003654e)**: Pass "start time" and "commit time" to Profiler callback (#12852) //<Brian Vaughn>//
- **[dc3b144f4](facebook/react@dc3b144f4)**: Treat Rollup "warnings" as errors (#12868) //<Dan Abramov>//
- **[d7b9b4921](facebook/react@d7b9b4921)**: Fix react native example links in README of 'react-reconciler' (#12871) //<Kevin (Kun) "Kassimo" Qian>//
- **[9bed4a6ae](facebook/react@9bed4a6ae)**: https in reactProdInvariant text (#12869) //<Sophie Alpert>//
- **[47b003a82](facebook/react@47b003a82)**: Resolve host configs at build time (#12792) //<Dan Abramov>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions c0fe8d6...ae14317

Reviewed By: bvaughn

Differential Revision: D8458731

fbshipit-source-id: afefaa50685d43e70c8ea85c70d2e29dee311cbb
macdoum1 pushed a commit to macdoum1/react-native that referenced this issue Jun 28, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs facebook#18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix facebook#12994 and facebook#6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook#18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
macdoum1 pushed a commit to macdoum1/react-native that referenced this issue Jun 28, 2018
Summary:
This sync includes the following changes:
- **[ae14317d6](facebook/react@ae14317d6)**: Inline fbjs/lib/emptyFunction (facebook#13054) //<Dan Abramov>//
- **[72434a768](facebook/react@72434a768)**: Remove or inline some fbjs dependencies (facebook#13046) //<Dan Abramov>//
- **[64c54edea](facebook/react@64c54edea)**: Adding movementX and movementY to synthenticMouseEvent fixes facebook#6723 (facebook#9018) //<Jason Williams>//
- **[9bd4d1fae](facebook/react@9bd4d1fae)**: Synchronously restart when an error is thrown during async rendering (facebook#13041) //<Andrew Clark>//
- **[9bda7b28f](facebook/react@9bda7b28f)**: Suspended high pri work forces lower priority work to expire early  (facebook#12965) //<Andrew Clark>//
- **[2e7577907](facebook/react@2e7577907)**: Fix incorrect data in compositionend event with Korean IME on IE11 (facebook#10217) (facebook#12563) //<Crux>//
- **[bc963f353](facebook/react@bc963f353)**: setJSResponder in Fabric renderer (facebook#13031) //<Sebastian Markbåge>//
- **[051637da6](facebook/react@051637da6)**: Extract Fabric event handlers from canonical props (facebook#13024) //<Sebastian Markbåge>//
- **[2a8085980](facebook/react@2a8085980)**: Remove rAF fork (facebook#12980) //<Flarnie Marchan>//
- **[e0c78344e](facebook/react@e0c78344e)**: Retry on error if there's lower priority pending work (facebook#12957) //<Andrew Clark>//
- **[9725065eb](facebook/react@9725065eb)**: Update bundle sizes for 16.4.1 release //<Dan Abramov>//
- **[0b87b2790](facebook/react@0b87b2790)**: Updating package versions for release 16.4.1 //<Dan Abramov>//
- **[036ae3c6e](facebook/react@036ae3c6e)**: Use native event dispatching instead of Simulate or SimulateNative (facebook#13023) //<Philipp Spieß>//
- **[945fc1bfc](facebook/react@945fc1bfc)**: Call gDSFP with the right state in react-test-render (facebook#13030) //<Rafał Ruciński>//
- **[392530104](facebook/react@392530104)**: Remove feature flag around 'getDerivedStateFromProps' bug fix (facebook#13022) //<Flarnie Marchan>//
- **[1594409fa](facebook/react@1594409fa)**: Scheduler depends on common packages (facebook#13020) //<Dan Abramov>//
- **[d5c11193e](facebook/react@d5c11193e)**: Added production profiling bundle type (facebook#12886) //<Brian Vaughn>//
- **[ec60457bc](facebook/react@ec60457bc)**: Popping context is O(1) in SSR (facebook#13019) //<Dan Abramov>//
- **[30bc8ef79](facebook/react@30bc8ef79)**: Allow multiple root children in test renderer traversal API (facebook#13017) //<Dan Abramov>//
- **[d480782c4](facebook/react@d480782c4)**: Don’t error when returning an empty Fragment (facebook#12966) //<Philipp Spieß>//
- **[4ac6f133a](facebook/react@4ac6f133a)**: Fallback to event.srcElement for IE9 (facebook#12976) //<Nathan Hunzaker>//
- **[23be4102d](facebook/react@23be4102d)**: Fixed an issue with nested contexts unwinding when server rendering. Issue facebook#12984 (facebook#12985) //<Eric Soderberg>//
- **[d0d428064](facebook/react@d0d428064)**: Remove old reference to inst._wrapperState (facebook#12987) //<Nathan Hunzaker>//
- **[c78957eac](facebook/react@c78957eac)**: Fix an SVG focusing crash in IE11 (facebook#12996) //<Jifa Jiang>//
- **[bfb12ebb5](facebook/react@bfb12ebb5)**: delete a couple of redundant lines in performWorkOnRoot() in ReactFiberScheduler.js (facebook#13003) //<Nathan Quarles>//
- **[394b17eed](facebook/react@394b17eed)**: Update custom renderer docs //<Dan Abramov>//
- **[188c4252a](facebook/react@188c4252a)**: Fix react-dom ReferenceError requestAnimationFrame in non-browser env (facebook#13000) (facebook#13001) //<Ivan Babak>//
- **[9cf3733a9](facebook/react@9cf3733a9)**: update comment in computeAsyncExpiration() to reflect code (facebook#12994) //<Nathan Quarles>//
- **[c5a733e1e](facebook/react@c5a733e1e)**: Fix links of docs on the comment (facebook#12795) //<Ende93>//
- **[36546b513](facebook/react@36546b513)**: Set the correct initial value on input range (facebook#12939) //<Maxime Nory>//
- **[15767a8f8](facebook/react@15767a8f8)**: [scheduler] 5/n Error handling in scheduler (facebook#12920) //<Flarnie Marchan>//
- **[3118ed9d6](facebook/react@3118ed9d6)**: Expose unstable_interactiveUpdates on ReactDOM (facebook#12943) //<Andrew Clark>//
- **[524a74331](facebook/react@524a74331)**: Fix for Flow issues in SimpleCacheProvider (facebook#12942) //<Flarnie Marchan>//
- **[ae57b125c](facebook/react@ae57b125c)**: [simple-cache-provider] Use LRU cache eviction (facebook#12851) //<Andrew Clark>//
- **[e0a03c1b4](facebook/react@e0a03c1b4)**: Extend input type check in selection capabilities (facebook#12062) (facebook#12135) //<Spyros Ioakeimidis>//
- **[79a740c6e](facebook/react@79a740c6e)**: Rename variables to remove references to 'global' global (facebook#12931) //<Flarnie Marchan>//
- **[ff724d3c2](facebook/react@ff724d3c2)**: [scheduler] 4/n Allow splitting out `schedule` in fb-www, prepare to fix polyfill issue internally (facebook#12900) //<Flarnie Marchan>//
- **[83f76e4db](facebook/react@83f76e4db)**: ForwardRefs supports propTypes (facebook#12911) //<Brian Vaughn>//
- **[8aeea5afa](facebook/react@8aeea5afa)**: Do not assign node.value on input creation if no change will occur (facebook#12925) //<Nathan Hunzaker>//
- **[aa85b0fd5](facebook/react@aa85b0fd5)**: Upgrade to Jest 23 (facebook#12894) //<Simen Bekkhus>//
- **[61777a78f](facebook/react@61777a78f)**: [scheduler] 3/n Use a linked list instead of map and queue for callback storage (facebook#12893) //<Flarnie Marchan>//
- **[e7bd3d59a](facebook/react@e7bd3d59a)**: No longer expose ReactNativeComponentTree (facebook#12904) //<Sebastian Markbåge>//
- **[f35d989be](facebook/react@f35d989be)**: TestRenderer warns if flushThrough is passed the wrong params (facebook#12909) //<Brian Vaughn>//
- **[557870067](facebook/react@557870067)**: Record "actual" times for all Fibers within a Profiler tree (alt) (facebook#12910) //<Brian Vaughn>//
- **[76e07071a](facebook/react@76e07071a)**: [scheduler] 2/n Adding 'schedule' fixture (facebook#12884) //<Flarnie Marchan>//
- **[345e0a71a](facebook/react@345e0a71a)**: Improve tests for 'schedule' module (facebook#12880) //<Flarnie Marchan>//
- **[8765d6089](facebook/react@8765d6089)**: Update bundle sizes for 16.4.0 release //<Andrew Clark>//
- **[d427a563d](facebook/react@d427a563d)**: Updating package versions for release 16.4.0 //<Andrew Clark>//
- **[53852a887](facebook/react@53852a887)**: add functional components warning about legacy context api (facebook#12892) //<Chang Yan>//
- **[fe747a51c](facebook/react@fe747a51c)**: Add React.Timeout to getComponentName (facebook#12890) //<Toru Kobayashi>//
- **[c601f7a64](facebook/react@c601f7a64)**: add siblings Timeout components test case (facebook#12862) //<Chang Yan>//
- **[735035837](facebook/react@735035837)**: add legacy context API warning in strict mode (facebook#12849) //<Chang Yan>//
- **[e88579184](facebook/react@e88579184)**: Fix a regression that caused us to listen to extra events at the top (facebook#12878) //<Dan Abramov>//
- **[7c0aca289](facebook/react@7c0aca289)**: Rollup freeze: false (facebook#12879) //<Brian Vaughn>//
- **[33289b530](facebook/react@33289b530)**: Tests and fixes for 'timing out' behavior (facebook#12858) //<Flarnie Marchan>//
- **[ad27845cc](facebook/react@ad27845cc)**: Fix double-firing submit events (facebook#12877) //<Sophie Alpert>//
- **[dd5fad296](facebook/react@dd5fad296)**: Update Flow to 0.70 (facebook#12875) //<Dan Abramov>//
- **[13003654e](facebook/react@13003654e)**: Pass "start time" and "commit time" to Profiler callback (facebook#12852) //<Brian Vaughn>//
- **[dc3b144f4](facebook/react@dc3b144f4)**: Treat Rollup "warnings" as errors (facebook#12868) //<Dan Abramov>//
- **[d7b9b4921](facebook/react@d7b9b4921)**: Fix react native example links in README of 'react-reconciler' (facebook#12871) //<Kevin (Kun) "Kassimo" Qian>//
- **[9bed4a6ae](facebook/react@9bed4a6ae)**: https in reactProdInvariant text (facebook#12869) //<Sophie Alpert>//
- **[47b003a82](facebook/react@47b003a82)**: Resolve host configs at build time (facebook#12792) //<Dan Abramov>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions c0fe8d6...ae14317

Reviewed By: bvaughn

Differential Revision: D8458731

fbshipit-source-id: afefaa50685d43e70c8ea85c70d2e29dee311cbb
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
grabbou pushed a commit to react-native-community/cli that referenced this issue Sep 26, 2018
Summary:
The original proguard rules are put in the template, which is not very convenient and easy to get wrong. Because new rules get put, people also has two copy paste the rule. And there are also existing project import react native as a dependency. So the best way to  keep a android library project proguard rule is to manage the rule itself, using `consumerProguardFiles` like [dagger](https://github.com/JakeWharton/butterknife/blob/46baef6d96e93a1872efa17fdfc1d2af59b36f0c/butterknife/build.gradle#L9) and other android library project.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Use RNTester to build the release flavor (now it has bugs facebook/react-native#18460, I keep my change in local for now), after build success, run to check if crash.

In the process, I also fix facebook/react-native#12994 and facebook/react-native#6624 by adding the following to proguard rules
```proguard
-keep,includedescriptorclasses class com.facebook.react.bridge.** { *; }
```

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

[ANDROID] [ENHANCEMENT and BUGFIX] [Proguard rules] - inline and fix proguard rules .

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
Closes facebook/react-native#18461

Differential Revision: D7527533

Pulled By: hramos

fbshipit-source-id: 447dbc16983bcfb597187b40c1be3987a8c5a832
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants