-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third party podspecs should only include required files #14654
Comments
@david50407 Can you Please share the updated excluded files Folly.podspec file? |
Have you tried to update past f3f44ee to see if the problem is fixed for you? This effectively remove all header files from the third party podspecs. |
This is still broken on RN 0.47.2 which include f3f44ee |
This is still broken!! RN 0.49.3 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
We use GitHub Issues exclusively for tracking bugs in React Native.
Reporting bugs
Want to report a bug? Please read the bug reporting guidelines: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#bugs
Description
Use React Native with CocoaPods. But all
#include <math.h>
(Like Yoga.h) throw a warning and go to findMath.h
from Folly and caused#include <limits>
not found (in this issue facebook/folly#617 )Reproduction Steps
Init react native project and use CocoaPods with
Podfile
:Then build iOS project.
Solution
Create a new React Native project and compare the default project without pods to with pods.
Then exclude the files which is not listed in the default project from
Folly.podspec
.After only includes necessary files, the build passed
Additional Information
Files from default project I included finally:
The text was updated successfully, but these errors were encountered: