-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Borders] Lines visible with borderRadius, borderWidth and borderColor #2089
Comments
Yep, this is reported here #2017 |
You can possibly accomplish the same with 2 circles? https://rnplay.org/apps/dhvHVw |
This looks different than #2017. My initial guess is that this is a bug w Facebook rendering while 2017 is about apple rendering. |
The visible lines are due to the anti-aliasing when drawing the four trapezoids for the border. Not quite sure how to make them less visible without drawing the image at an unnecessarily larger scale and downsizing the image to be drawn. |
Summary: public The iOS border rendering code did not follow the CSS spec in cases where the sum of adjacent border radii was greater than the width of the view, resulting in drawing glitches such as pixel smear and borders appearing stretched or squashed. This diff brings our implementation closer to spec-compliance in these cases. I also fixed a longstanding issue with ghostly diagonal lines appearing at the corners due to antialiasing rounding errors! Fixes #1572 #2089 #4604 Reviewed By: tadeuzagallo Differential Revision: D2811249 fb-gh-sync-id: c3dd2721e0a01a432fa4dc78daa05680595edd08
Fixed in b115277 |
Summary: public The iOS border rendering code did not follow the CSS spec in cases where the sum of adjacent border radii was greater than the width of the view, resulting in drawing glitches such as pixel smear and borders appearing stretched or squashed. This diff brings our implementation closer to spec-compliance in these cases. I also fixed a longstanding issue with ghostly diagonal lines appearing at the corners due to antialiasing rounding errors! Fixes facebook#1572 facebook#2089 facebook#4604 Reviewed By: tadeuzagallo Differential Revision: D2811249 fb-gh-sync-id: c3dd2721e0a01a432fa4dc78daa05680595edd08
There's a rendering issue when using
borderRadius
,borderWidth
andborderColor
, you see lines appearing between each border:The above image was produced with the following code on the latest master (75b220d), same happens with the latest released version (0.7.1):
The text was updated successfully, but these errors were encountered: