-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packager is required to live in node_modules of app #408
Comments
Do you have any suggestion on what the best way to handle this? |
Can you run the packager manually from your fork with --root <path/to/project>? |
@sahrens starting packager.sh with --root does work. @amasad thoughts on starting packager with |
It's preferred that each project has its own copy of the packager in node_modules for typical development so you don't have to worry about versioning between libs. This doesn't really work with multiple React Native projects yet since the packager runs continuously on the same port, but there is discussion of adding a status endpoint so you could kill a currently running packager if it reports the wrong version via status and start the right one for that project automatically.
|
I've resolved this issue by creating a THIS_DIR=$(dirname "$0")
node_modules/react-native/packager/packager.sh --root $THIS_DIR |
Closes facebook#408 I checked some that currently returns unit: - PushNotificationIOS doesn't returns a thing https://github.com/facebook/react-native/blob/6677f405a2de0833286671bc308230ea1d574f82/Libraries/PushNotificationIOS/PushNotificationIOS.js#L187 - Linking too https://github.com/facebook/react-native/blob/6677f405a2de0833286671bc308230ea1d574f82/Libraries/Linking/Linking.js#L38 - Dimensions neither https://github.com/facebook/react-native/blob/6677f405a2de0833286671bc308230ea1d574f82/Libraries/Utilities/Dimensions.js#L103 - and AppState doesn't https://github.com/facebook/react-native/blob/a442e0b63526405249ddf50e58f1fdc618c789bc/Libraries/AppState/AppState.js#L79
This reverts commit bac7fd5. Closes facebook#408
When working on a react-native fork, it is desirable to have your apps symlink to your repo directory rather than each app having their own instance of react-native in node_modules. Currently this is not supported by packager, as it assumes that the directory's physical location is within the projects node_module folder.
https://github.com/facebook/react-native/blob/master/packager/packager.js#L49-L55
The text was updated successfully, but these errors were encountered: