Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to change title colour of RefreshControl #6812

Closed
jdmunro opened this issue Apr 5, 2016 · 3 comments
Closed

Not possible to change title colour of RefreshControl #6812

jdmunro opened this issue Apr 5, 2016 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jdmunro
Copy link
Contributor

jdmunro commented Apr 5, 2016

As far as I can tell there's no way to change the title colour if you provide a title for RefreshControl:

<RefreshControl
  refreshing={isRankDataRefreshing}
  onRefresh={onRefreshRankings}
  title={'Refreshing'}
  tintColor='white'
  progressBackgroundColor='white'
/>

By default the colour will be black. This is problematic if you have a non-standard background colour:

simulator screen shot 5 apr 2016 10 55 51

I'm not sure if this is the best approach, but one solution would just be to add an additional prop, titleColor, for instance.

@janicduplessis
Copy link
Contributor

I think a titleColor prop is fine, the title property of the UIRefreshControl on iOS is an NSAttributedString so it should be simple to change the color. Would you like to submit a PR that implements that?

@skv-headless
Copy link
Contributor

@janicduplessis could you please take a look at #6970? Looks terrible on dark background 😞

@janicduplessis
Copy link
Contributor

@skv-headless Oh, I missed that one :). I'll take a look today.

@ghost ghost closed this as completed in 849a0f3 Apr 16, 2016
rozele referenced this issue in microsoft/react-native-windows May 25, 2016
Summary:Closes #6812

![simulator screen shot 14 apr 2016 12 13 36](https://cloud.githubusercontent.com/assets/1488195/14521441/0abccf5c-0232-11e6-94dc-0ebdbfac4b3f.png)
Closes facebook/react-native#6970

Differential Revision: D3189244

fb-gh-sync-id: 7625b6ab5859aaa20bc0cb379855c5daeb584abf
fbshipit-source-id: 7625b6ab5859aaa20bc0cb379855c5daeb584abf
zebulgar pushed a commit to nightingale/react-native that referenced this issue Jun 18, 2016
Summary:Closes facebook#6812

![simulator screen shot 14 apr 2016 12 13 36](https://cloud.githubusercontent.com/assets/1488195/14521441/0abccf5c-0232-11e6-94dc-0ebdbfac4b3f.png)
Closes facebook#6970

Differential Revision: D3189244

fb-gh-sync-id: 7625b6ab5859aaa20bc0cb379855c5daeb584abf
fbshipit-source-id: 7625b6ab5859aaa20bc0cb379855c5daeb584abf
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants