Add viewConfig to RCTSlider Component, fix #10158 #10238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
facebook-github-bot
added
the
CLA Signed
|
@leeight updated the pull request - view changes |
1 similar comment
|
@leeight updated the pull request - view changes |
facebook-github-bot
added
the
CLA Signed
javache
reviewed
Oct 11, 2016
| this._component.setNativeProps( | ||
| this._propsAnimated.__getAnimatedValue() | ||
| ); | ||
| if (this._component.viewConfig != null) { |
There was a problem hiding this comment.
Can you throw an error here instead of just dropping the change?
|
@leeight updated the pull request - view changes |
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
the
CLA Signed
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Oct 13, 2016
Summary: And check componet.viewConfig before call component.setNativeProps method. FIX #10158 Closes facebook/react-native#10238 Differential Revision: D4008640 Pulled By: javache fbshipit-source-id: 1bf9b34c0e56f1ffbcd31ae64b3cbafe77a9a1fd
michalchudziak
pushed a commit
to michalchudziak/react-native-slider
that referenced
this pull request
Feb 8, 2019
Summary: And check componet.viewConfig before call component.setNativeProps method. FIX #10158 Closes facebook/react-native#10238 Differential Revision: D4008640 Pulled By: javache fbshipit-source-id: 1bf9b34c0e56f1ffbcd31ae64b3cbafe77a9a1fd
james-watkin
added a commit
to james-watkin/react-native-slider
that referenced
this pull request
Dec 28, 2021
Summary: And check componet.viewConfig before call component.setNativeProps method. FIX #10158 Closes facebook/react-native#10238 Differential Revision: D4008640 Pulled By: javache fbshipit-source-id: 1bf9b34c0e56f1ffbcd31ae64b3cbafe77a9a1fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And check componet.viewConfig before call component.setNativeProps method.
FIX #10158