Fix skew transform on native side (iOS & Android) #12106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
MaxGraey
referenced
this pull request
Jan 28, 2017
Summary: In theory, we should be able to animate any non-layout property, including custom ones. While there is still work to be done on the native side to fully enable this, we should start by dropping the prop whitelist. Closes #10658 Differential Revision: D4379031 Pulled By: ericvicenti fbshipit-source-id: fe9c30ea101e93a8b260d7d09a909fafbb82fee6
|
Thanks for fixing this! @facebook-github-bot shipit |
|
@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks! |
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: According to facebook#11992 fix skew transform in native code as well janicduplessis vjeux Closes facebook#12106 Differential Revision: D4479880 fbshipit-source-id: d84780842b555f6352d84d229b5b6c5c3c6a0647
|
I tried, still not working on android platfom but ios, why? <View style={{width:100,height:100,backgroundColor:'red',transform:[{skewX:'30deg'}]}} > |
|
@lirui0407 See my last comment in this topic |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #11992 fix skew transform in native code as well
@janicduplessis @vjeux