[UIExplorer] fix gratuitous app crash #12110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Oh, I see, the extrapolate prop was in the wrong object. @facebook-github-bot shipit |
|
@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See #12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes #12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Feb 8, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook/react-native#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Now it fails <img src="https://cloud.githubusercontent.com/assets/1488195/22402686/1bb46f5a-e61a-11e6-9c4a-7b01e7f89508.gif" width="300"/> **Test plan (required)** UIExplorer Closes facebook#12110 Differential Revision: D4480641 fbshipit-source-id: c9941e9cc2f0624c7120cfb17a3534c92207bf7a
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: This improves JS validations of the transform object and makes it a bit stricter (hence the breaking change). When moving transform objects parsing to native (facebook#10658) the validations got out of sync a bit, this makes sure JS validations are the same or stricter than the native ones to make sure we get consistent errors across platforms. See facebook#12110 for an example of an error that now gets caught by JS validations. Also added snapshot tests for the errors to make sure `processTransform` throws when passing invalid values. It only tests the validation since the object parsing is now done natively for iOS and Android. **Test plan** Test that there are no errors in UIExplorer Run new unit tests Closes facebook#12115 Differential Revision: D4488933 Pulled By: mkonicek fbshipit-source-id: a714e6175b2892284a44c870506165099efec1ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it fails
Test plan (required)
UIExplorer