Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whatwg-fetch to version ^2.0.3 #12962

Closed
wants to merge 2 commits into from
Closed

Conversation

kalman
Copy link
Contributor

@kalman kalman commented Mar 15, 2017

See #12961

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Mar 15, 2017
@kalman
Copy link
Contributor Author

kalman commented Mar 15, 2017

I've tested this with npm test, I don't know what else to do.

@facebook-github-bot
Copy link
Contributor

@kalman I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@ide
Copy link
Contributor

ide commented Aug 11, 2017

Commits like these are deceptively tricky since most of the work is combing through the changelog and making sure it didn't break any behavior currently used, and then trying it in a couple of apps. Can you construct a reproduceable test plan and explain why you're confident in this change?

@kalman
Copy link
Contributor Author

kalman commented Aug 11, 2017

Yep, understood.

I don't have the time right now to test this super exhaustively though unfortunately :-(

@stale
Copy link

stale bot commented Oct 13, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 13, 2017
@stale stale bot closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants