Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to version 2 of whatwg-fetch #12961

Closed
kalman opened this issue Mar 15, 2017 · 1 comment
Closed

Upgrade to version 2 of whatwg-fetch #12961

kalman opened this issue Mar 15, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@kalman
Copy link
Contributor

kalman commented Mar 15, 2017

Description

I'm seeing issues with fetch on iOS, like the response not having an arrayBuffer property. I am guessing this is related to RN using version 1 of whatwg-fetch:

https://github.com/facebook/react-native/blob/master/package.json#L205

From reading the code it seems version 1 does support arrayBuffer, but they've fixed bugs relating to feature detection in version 2 onwards.

Reproduction

Fetch a blob, access the arrayBuffer property on the response.

Solution

Upgrade to version 2 of whatwg-fetch? Seems like a good idea either way.

Additional Information

  • React Native version: 0.42.0-rc.0 (haven't tested with 0.43)
  • Platform: iOS
  • Operating System: macOS 10
  • Dev tools: Xcode 8
kalman added a commit to kalman/react-native that referenced this issue Mar 15, 2017
@kalman
Update whatwg-fetch to version ^2.0.3
d8e6a1c 
See facebook#12961
@kalman kalman mentioned this issue Mar 15, 2017
Closed
@hramos
Copy link
Contributor

hramos commented May 25, 2017

We're cutting down on the number of outstanding issues, in order to allow us to focus. I'm closing this issue because it has been open for over 60 days with no activity. If you think it should still be opened let us know why. PRs are always welcome.

@hramos hramos closed this as completed May 25, 2017
@hramos hramos added the Icebox label May 26, 2017
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hramos @kalman @react-native-bot