-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RCTLinking.m #13881
Update RCTLinking.m #13881
Conversation
Referencing openUrl inside App extension isnt considered a correct
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Would appreciate if someone could review and check this code in. This PR blocks us from using react-navigation in our iMessage app extension. And given that Navigator is removed in the latest react-native release, the priority of this fix going in is much higher for us |
Could you merge this again? It seems you've picked up a bunch of unrelated changes. |
Thanks for submitting a PR! Please read these instructions carefully:
master
branch, NOT a "stable" branch.Motivation (required)
What existing problem does the pull request solve?
React-navigation requires LinkingIOS to be referenced. When I include the RCTLinkingIOS subspec, it exposes more app extension unsafe code. This fix updates the RCTLinkingIOS code to
Test Plan (required)
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
Made changes locally and tested on my local device that the react-native code compiles with RCTLinkingIOS subspec specified
If you have added code that should be tested, add tests.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.