Expose content-available APS key for iOS silent push #14584
Conversation
facebook-github-bot
added
CLA Signed
| @@ -72,11 +72,13 @@ class NotificationExample extends React.Component { | |||
|
|
|||
| _sendNotification() { | |||
| require('RCTDeviceEventEmitter').emit('remoteNotificationReceived', { | |||
| remote: true, | |||
There was a problem hiding this comment.
This property is added by the iOS native code for remote notification (handleRemoteNotificationReceived) and the PushNotificationIOS constructor looks for it otherwise it will not look for the aps object.
| @@ -115,9 +117,15 @@ class NotificationExample extends React.Component { | |||
| } | |||
|
|
|||
| _onRemoteNotification(notification) { | |||
| const result = `Alert message: ${notification.getMessage()} | |||
| @@ -485,6 +487,13 @@ class PushNotificationIOS { | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the content-available number from the `aps` object | |||
| */ | |||
| getContentAvailable(): ?number { | |||
There was a problem hiding this comment.
Why the returning type is different from _contentAvailable.
There was a problem hiding this comment.
Looks like the only possible values are 1 and null, right?
There was a problem hiding this comment.
yes, it can be 1 or null/undefined so this is why it is optional. I aligned _contentAvailable member with the other private members in this class which add the optional flag only in the getter.
There was a problem hiding this comment.
Can we declare special type type ContentAvailable = 1; (https://flow.org/en/docs/types/unions/) and then use it as ?ContentAvailable? (I am not sure.) Or maybe we can create special already optional type?
There was a problem hiding this comment.
Create a ContentAvailable type which is already optional
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: <details> Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. Please read the [Contribution Guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md) to learn more about contributing to React Native. </details> _What existing problem does the pull request solve? In iOS when sending a silent push notification you need to configure the 'content-available' APS key to the value of 1 (When this key is present, the system wakes up your app in the background and delivers the notification to its app delegate, see [apple docs](https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/PayloadKeyReference.html#//apple_ref/doc/uid/TP40008194-CH17-SW1)). This PR exposes this property to the notification event handler so app code can handle silent push scenario specifically. Currently this property is not available. I've updated the PushNotificationIOSExample in the RNTester. 1. Open RNTester in xcode 2. Enable the push notifications capability 3. run on device 4. Go to PushNotificationIOS 5. click on "send fake notification" 6. verify alert message contains 'content-available' with a value of 1. Closes facebook/react-native#14584 Differential Revision: D5279181 Pulled By: shergin fbshipit-source-id: d2288e147d89ba267f54265d819aa0a9969095e7
masterbranch, NOT a "stable" branch.Please read the Contribution Guidelines to learn more about contributing to React Native.
Motivation (required)
_What existing problem does the pull request solve?
In iOS when sending a silent push notification you need to configure the 'content-available' APS key to the value of 1 (When this key is present, the system wakes up your app in the background and delivers the notification to its app delegate, see apple docs).
This PR exposes this property to the notification event handler so app code can handle silent push scenario specifically. Currently this property is not available.
Test Plan (required)
I've updated the PushNotificationIOSExample in the RNTester.