Apple TV: Enable long presses on TV remote; dev menu on TV device; example code #15221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
javache
reviewed
Jul 28, 2017
React/Base/RCTTVRemoteHandler.m
Outdated
| { | ||
| [self sendAppleTVEvent:@"longPlayPause" toView:r.view]; | ||
| // If shake to show is enabled on device, use long play/pause event to show dev menu | ||
| [[NSNotificationCenter defaultCenter] postNotificationName:@"RCTShowDevMenuNotification" object:nil]; |
There was a problem hiding this comment.
Instead of using a string here, can you can change the definition of RCTShowDevMenuNotification to extern (put an RCT_EXTERN definition in the header)
facebook-github-bot
added
GH Review: accepted
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Sep 11, 2017
…ample code Summary: **Motivation** Properly support long presses on the Apple TV remote, and also enable dev menu functionality on a real Apple TV device (shaking an Apple TV doesn't work 😄 ) **Test plan** New example added to `RNTester`. Closes facebook/react-native#15221 Differential Revision: D5526463 Pulled By: javache fbshipit-source-id: a61051e86bc82a9561eefc1704bed6b1f2617e05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Properly support long presses on the Apple TV remote, and also enable dev menu functionality on a real Apple TV device (shaking an Apple TV doesn't work 😄 )
Test plan
New example added to
RNTester.