Use BitmapRegionDecoder to efficiently crop images on Android #15439
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@faifai21 This is probably a stupid question, but fear is stronger than shame :) |
|
@rahamin1, look ta this code link . So this work's automatically for you when you use in your code. But now I am testing code with many images from api with size >2500px and problems(black empty block instead image, app crashing) occurs same like before that commit with BitmapRegionDecoder. I think image resizing is the only solution if you want to get rid of memory leak with fetching large images. May be @faifai21 has another solution. |
|
Thanks @noth8 I cannot resize since I am displaying previews of web articles in a ListView, and the images are taken from the articles. Hopefully @faifai21 has other insights. |
Summary: The Android ImageEditingManager is inefficient and slow when cropping images. It loads the full resolution image into memory and then crops it. This leads to slow performance and occasional OutOfMemory Exceptions. [BitmapRegionDecoder](https://developer.android.com/reference/android/graphics/BitmapRegionDecoder.html) can be used to crop without needing to load the full resolution image into memory. Using it is much more efficient and much faster. Relevant issue: facebook/react-native#10470 Attempt to crop a very large image (2000x2000) on Android. With this change, the crop should happen almost instantly. On the master branch, it should take 2-3 seconds (and might run out of memory). Please let me know if there's anything else I can provide. Closes facebook/react-native#15439 Differential Revision: D5628223 Pulled By: shergin fbshipit-source-id: bf314e76134cd015380968ec4533225e724c4b26
The Android ImageEditingManager is inefficient and slow when cropping images. It loads the full resolution image into memory and then crops it. This leads to slow performance and occasional OutOfMemory Exceptions.
BitmapRegionDecoder can be used to crop without needing to load the full resolution image into memory. Using it is much more efficient and much faster.
Relevant issue: #10470
Test Plan
Attempt to crop a very large image (2000x2000) on Android. With this change, the crop should happen almost instantly. On the master branch, it should take 2-3 seconds (and might run out of memory).
Please let me know if there's anything else I can provide.