[NavigatorIOS] allow font family for title #1667
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@ojkelly - can you squash this into one commit please? |
Update RCTWrapperViewController.m Update RCTNavItem.h Update RCTNavItemManager.m Update NavigatorIOS.ios.js Update NavigatorIOSColorsExample.js
ojkelly
force-pushed
the
navigator-allow-font-family
branch
from
715d911
to
4a4624b
Compare
| @@ -66,6 +66,7 @@ var NavigatorIOSColors = React.createClass({ | |||
| tintColor="#FFFFFF" | |||
| barTintColor="#183E63" | |||
| titleTextColor="#FFFFFF" | |||
| fontFamily="Helvetica" | |||
There was a problem hiding this comment.
Could you change this to "titleFontFamily"?
There was a problem hiding this comment.
I'm pretty certain this affects the font family of the left and right buttons as well, so I don't know if titleFontFamily would be applicable?
I can test this and confirm for you if this will affect more than just the title.
There was a problem hiding this comment.
I would be surprised if that were true, but if so then I agree fontFamily would make sense for the name.
There was a problem hiding this comment.
Just tested, it appears to only affect the title. I must have been playing with some other title.
I'll get that changed and update the PR.
|
@ojkelly updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@ojkelly Can you rebase it please? |
|
@brentvatne no worries, sorry I didn't have the time to complete it. Not doing much with react-native until late Jan unfortunately. |
|
@ojkelly - no problem :) see you around here in late Jan then 🎱 |
Allow different font families in the title and right and left buttons.
Only caveat, is that it requires the use of the machine name of the font, such as
Helvetica-BoldItalic, for bold italic Helvetica.I've added an example to UIExplorer.