Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height styling when keyboard closed #16965

Closed
wants to merge 2 commits into from

Conversation

shauns
Copy link

@shauns shauns commented Nov 24, 2017

Closes #13754

Motivation

Fixing previously reported bug #13754

Test Plan

Video here https://imgur.com/a/3IgqP

Release Notes

[GENERAL] [BUGFIX] [KeyboardAvoidingView] - Correct height behaviour when keyboard closed

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2017
@facebook-github-bot
Copy link
Contributor

@shauns I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@submitteddenied
Copy link

Hey @shauns, happy new year!

I ran across this issue today, do you have time to take another look at this PR?

@react-native-bot react-native-bot added Bug Fix 🐛 Ran Commands One of our bots successfully processed a command. labels Mar 16, 2018
@WaldoJeffers
Copy link
Contributor

WaldoJeffers commented Apr 16, 2018

I think this needs to be merged as soon as possible, it's a very simple fix which solves a very annoying issue for a lot of users. What can we do to have this move forward? @hramos

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test plan and the explanation. The code comment also explains that this code should only be used when this.state.bottom > 0 but it isn't validated anywhere. I'll land this.

@pull-bot
Copy link

Warnings
⚠️

📋 Changelog - This PR appears to be missing Changelog. Please add a section called "changelog" and format it as explained in the contributing guidelines.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 29, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@shauns merged commit 745484c into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 29, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 29, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
Summary:
Closes facebook#13754

Fixing previously reported bug facebook#13754

Video here https://imgur.com/a/3IgqP

[GENERAL] [BUGFIX] [KeyboardAvoidingView] - Correct height behaviour when keyboard closed
Pull Request resolved: facebook#16965

Differential Revision: D13860208

Pulled By: cpojer

fbshipit-source-id: 9ae7f81fd24999518a6ae85016d4f75dac3c4274
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Ran Commands One of our bots successfully processed a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyboardAvoidingView with behavior="height" doesn't resize back on keyboard close
8 participants