[Dev] Update to Danger 2.0

.circleci/config.yml

@@ -12,14 +12,13 @@ aliases:
 
   - &restore-cache-analysis
     keys:
-      - v1-analysis-dependencies-{{ arch }}-{{ .Branch }}-{{ checksum "package.json" }}{{ checksum "danger/package.json" }}
+      - v1-analysis-dependencies-{{ arch }}-{{ .Branch }}-{{ checksum "package.json" }}
       # Fallback in case checksum fails
       - v1-analysis-dependencies-{{ arch }}-{{ .Branch }}-
   - &save-cache-analysis
     paths:
-      - danger/node_modules
       - node_modules
-    key: v1-analysis-dependencies-{{ arch }}-{{ .Branch }}-{{ checksum "package.json" }}{{ checksum "danger/package.json" }}
+    key: v1-analysis-dependencies-{{ arch }}-{{ .Branch }}-{{ checksum "package.json" }}
 
   - &restore-cache-android-packages
     keys:
@@ -421,22 +420,12 @@ jobs:
       - checkout
       - restore-cache: *restore-cache-analysis
       - run: *install-node-dependencies
-      - run:
-          name: Install Dependencies
-          command: |
-            if [ -n "$CIRCLE_PULL_REQUEST" ]; then
-              npm install github@0.2.4
-              cd danger
-              npm install --no-package-lock --no-spin --no-progress
-            else
-              echo "Skipping dependency installation."            
-            fi
       - save-cache: *save-cache-analysis
       - run:
           name: Analyze Pull Request
           command: |
             if [ -n "$CIRCLE_PULL_REQUEST" ]; then
-              cd danger && DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger
+              DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger
             else
               echo "Skipping pull request analysis."            
             fi

.eslintignore

@@ -7,4 +7,4 @@ Libraries/Renderer/*
 pr-inactivity-bookmarklet.js
 question-bookmarklet.js
 flow/
-danger/
+

.flowconfig

@@ -6,7 +6,7 @@
 .*/local-cli/templates/.*
 
 ; Ignore the Dangerfile
-<PROJECT_ROOT>/danger/dangerfile.js
+<PROJECT_ROOT>/dangerfile.js
 
 ; Ignore "BUCK" generated dirs
 <PROJECT_ROOT>/\.buckd/

.gitignore

@@ -47,7 +47,6 @@ local.properties
 node_modules
 *.log
 .nvm
-/danger/node_modules/
 
 # OS X
 .DS_Store

danger/dangerfile.js → dangerfile.js

@@ -124,7 +124,7 @@ if (!includesReleaseNotes) {
 
 // Tags PRs that have been submitted by a core contributor.
 // TODO: Switch to using an actual MAINTAINERS file.
-const taskforce = fs.readFileSync('../bots/IssueCommands.txt', 'utf8').split('\n')[0].split(':')[1];
+const taskforce = fs.readFileSync('bots/IssueCommands.txt', 'utf8').split('\n')[0].split(':')[1];
 const isSubmittedByTaskforce = includes(taskforce, danger.github.pr.user.login);
 if (isSubmittedByTaskforce) {
   markdown('@facebook-github-bot label Core Team');
@@ -171,7 +171,7 @@ if (!isMergeRefMaster && isMergeRefStable) {
 }
 
 // People can add themselves to CODEOWNERS in order to be automatically added as reviewers when a file matching a glob pattern is modified. The following will have the bot add a mention in that case.
-const codeowners = fs.readFileSync('../.github/CODEOWNERS', 'utf8').split('\n');
+const codeowners = fs.readFileSync('.github/CODEOWNERS', 'utf8').split('\n');
 let mentions = [];
 codeowners.forEach((codeowner) => {
   const pattern = codeowner.split(' ')[0];

package.json

@@ -200,6 +200,7 @@
   },
   "devDependencies": {
     "babel-eslint": "^7.2.3",
+    "danger": "^2.1.5",
     "eslint": "^3.19.0",
     "eslint-config-fb-strict": "^20.0.3",
     "eslint-config-fbjs": "^1.1.1",