Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress lint errors in Dialog module. remove abortOnError=false #19740

Closed
wants to merge 1 commit into from
Closed

Suppress lint errors in Dialog module. remove abortOnError=false #19740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions RNTester/android/app/build.gradle
View file
Open in desktop
Expand Up @@ -121,10 +121,6 @@ android {
}
}

lintOptions {
abortOnError false
}

// applicationVariants are e.g. debug, release
applicationVariants.all { variant ->
variant.outputs.each { output ->
Expand Down
2 changes: 2 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@

import javax.annotation.Nullable;

import android.annotation.SuppressLint;
import android.app.AlertDialog;
import android.app.Dialog;
import android.app.DialogFragment;
Expand All @@ -34,6 +35,7 @@ public AlertFragment() {
mListener = null;
}

@SuppressLint("ValidFragment")
public AlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
mListener = listener;
setArguments(arguments);
Expand Down
2 changes: 2 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@

import javax.annotation.Nullable;

import android.annotation.SuppressLint;
import android.app.Dialog;
import android.content.DialogInterface;
import android.os.Bundle;
Expand All @@ -27,6 +28,7 @@ public SupportAlertFragment() {
mListener = null;
}

@SuppressLint("ValidFragment")
public SupportAlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
mListener = listener;
setArguments(arguments);
Expand Down
8 changes: 0 additions & 8 deletions build.gradle
View file
Open in desktop
Expand Up @@ -35,12 +35,4 @@ allprojects {
url "$androidSdk/extras/m2repository/"
}
}

project.configurations.all {
resolutionStrategy.eachDependency { details ->
if (details.requested.group == 'com.facebook.soloader') {
details.useVersion "0.3.0"
}
}
}
}