Whitelist react-native-dom in haste/cli config defaults #20393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Context: it's the same approach that was used for |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @vincentriemer in c4bcca6. Once this commit is added to a release, you will see the corresponding version tag below the description at c4bcca6. If the commit has a single |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: This adds `react-native-dom` to `hasteImpl.js` because it's not currently possible to configure it from an out of tree platform. Also adds the relevant `providesModuleNodeModules` and `platforms` values to the default RN CLI config. This should hopefully be able to be removed once better support for out of tree platforms is implemented. Pull Request resolved: facebook/react-native#20393 Differential Revision: D9007186 Pulled By: hramos fbshipit-source-id: 67077860dc1fb191d80300fb980599ed76d5f91c
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
react-native-domtohasteImpl.jsbecause it's not currently possible to configure it from an out of tree platform. Also adds the relevantprovidesModuleNodeModulesandplatformsvalues to the default RN CLI config. This should hopefully be able to be removed once better support for out of tree platforms is implemented.Test Plan:
Confirmed that the updated config correctly builds an RNDom project by pulling my fork as a dependency (though it required some other changes for some unrelated
local-cliissues).Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CLI] [ENHANCEMENT] [jest/hasteImpl.js] - Whitelist react-native-dom in haste/cli config defaults