Fix event handlers for DPad arrows on Android TV

[krzysztofciombor]

Fixes #20924
DPad arrow events were missing from KEY_EVENTS_ACTIONS which meant that they were not broadcasted by TVEventHandler.

Test Plan:

1. DPad arrow events are correctly send to JS and are received by TVEventHandler

   this.tvEventHandler.enable(this, function(cmp, evt) {
     console.log('TVEvent', evt);
   });

   

2. All other events ("select", "playPause", etc.) are still sent correctly
   

3. Navigating between selectable components still works correctly

Release Notes:

[ANDROID] [BUGFIX] [AndroidTV] - Fixed missing DPad arrow event handlers

[Weetbix]

Thanks for this :) I tried to fix this myself a while ago but for some reason I couldn't get my RN changes to reflect in my app... Was going to try again but there you've already done it!

With this change it will be possible to manually navigate lists and items (as the built-in touchable navigation behavior is kind of broken), so thanks!

[mdvacca]

It looks good to me, but I would keep using the MapBuilder and we can avoid the static block. What do you think?

[mdvacca]

You can keep using MapBuilder here:

private static final Map<Integer, String> KEY_EVENTS_ACTIONS = MapBuilder.of()
.put(KeyEvent.KEYCODE_DPAD_CENTER, "select")
....
.build();

[krzysztofciombor]

@mdvacca Updated. Note that I had to use an explicit MapBuilder.<Integer, String>.builder() call, otherwise the returned Map would be of type Map<Object, Object>

[facebook-github-bot]

mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

@krzysztofciombor merged commit 4d71b15 into facebook:master.

---

Once this commit is added to a release, you will see the corresponding version tag below the description at 4d71b15. If the commit has a single master tag, it is not yet part of a release.