SuppressLint("MissingPermission") in Location, NetInfo, Vibration mod… #23294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Generated by 🚫 dangerJS |
react-native-bot
added
API: NetInfo
API: Vibration
🌐Networking
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit d53dbb0 into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
facebook#23294) Summary: Location, NetInfo and Vibration modules require its own permissions to work properly, and Android Studio and lint shows warning in the modules because permissions are not found in AndroidManifest.xml of ReactAndroid, due to that not all apps require these functionalities/permissions. Therefore, developers have to add required permissions if they want to use before mentioned functionalities. This PR suppresses missing permission warnings. [Android] [Changed] - Suppress missing permission warnings Pull Request resolved: facebook#23294 Differential Revision: D13959120 Pulled By: cpojer fbshipit-source-id: 10526f1218989b805528a5415e03371d5865be63
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
facebook#23294) Summary: Location, NetInfo and Vibration modules require its own permissions to work properly, and Android Studio and lint shows warning in the modules because permissions are not found in AndroidManifest.xml of ReactAndroid, due to that not all apps require these functionalities/permissions. Therefore, developers have to add required permissions if they want to use before mentioned functionalities. This PR suppresses missing permission warnings. [Android] [Changed] - Suppress missing permission warnings Pull Request resolved: facebook#23294 Differential Revision: D13959120 Pulled By: cpojer fbshipit-source-id: 10526f1218989b805528a5415e03371d5865be63
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Location, NetInfo and Vibration modules require its own permissions to work properly, and Android Studio and lint shows warning in the modules because permissions are not found in AndroidManifest.xml of ReactAndroid, due to that not all apps require these functionalities/permissions. Therefore, developers have to add required permissions if they want to use before mentioned functionalities.
This PR suppresses missing permission warnings.
Changelog
[Android] [Changed] - Suppress missing permission warnings
Test Plan
CI is green, everything works as usual. Just a small developer experience and QA improvement.