Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Follow us on Twitter link to new app screen #24806

Closed

Conversation

eliperkins
Copy link
Contributor

@eliperkins eliperkins commented May 10, 2019

Summary

This adds in a link to the @reactnative Twitter handle so our users can follow along with the latest and greatest of React Native!

Related to #24760

Changelog

[General] [Added] - Added link to @reactnative Twitter handle to Learn More section

Test Plan

  1. Fire up RNTester
  2. Navigate to the NewAppScreen
  3. Scroll to "Follow us on Twitter" link
  4. Tap touchable and verify that https://twitter.com/reactnative is opened

This adds in a link to the @reactnative Twitter handle so our users can follow along with the latest and greatest of React Native
@facebook-github-bot facebook-github-bot added the CLA Signed label May 10, 2019
@eliperkins eliperkins mentioned this pull request May 10, 2019
5 tasks
@react-native-bot react-native-bot added the Type: Enhancement label May 10, 2019
cpojer
cpojer approved these changes May 13, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Yessss!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@react-native-bot react-native-bot commented May 13, 2019

This pull request was successfully merged by @eliperkins in 0245fd7.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged label May 13, 2019
@eliperkins eliperkins deleted the add-twitter-to-new-app-screen branch May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Merged Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants