Add Fabric/Turbo Modules flags to iOS autolinking script #24867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
facebook-github-bot
added
CLA Signed
react-native-bot
added
API: Linking
Type: Enhancement
|
Yep, makes sense 👍 |
facebook-github-bot
approved these changes
May 16, 2019
There was a problem hiding this comment.
@fkgozali is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ericlewis in 9004029. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
) Summary: This makes it easier to enable fabric / turbo modules with the new fancy autolinking script. ## Changelog [iOS] [Added] - Add Fabric/Turbo Module flags to iOS autolinking script Pull Request resolved: facebook#24867 Differential Revision: D15368550 Pulled By: fkgozali fbshipit-source-id: 366cd9fb8b630011f9287ae762b985e4778de423
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: Oops, fixes syntax of autolink script landed in facebook#24867. ## Changelog [iOS] [Fixed] - Fixes syntax of autolink script Pull Request resolved: facebook#24882 Differential Revision: D15371272 Pulled By: cpojer fbshipit-source-id: 8538be040b8b116b9651dc26749ab8febad0fe7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes it easier to enable fabric / turbo modules with the new fancy autolinking script.
Changelog
[iOS] [Added] - Add Fabric/Turbo Module flags to iOS autolinking script
Test Plan
RNTester's TurboModules still work