[Internal] [Fix] - Bump CLI to 2.0.0-rc.2 #25241

thymikee · 2019-06-12T19:27:01Z

Summary

Fixing Metro validation issue. Hope that helps with fixing the CI 🤞.

Changelog

[Internal] [Fix] - Bump CLI to 2.0.0-rc.2

Test Plan

Fixed CI

pull-bot · 2019-06-12T19:29:17Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 07163fb

thymikee · 2019-06-12T20:26:33Z

Looks like this is a regression in jest-haste-map introduced in this PR: https://github.com/facebook/jest/pull/8056/files#diff-5c5055968e3661a18f280d5e3f10c969L738

The code was wrong earlier as well but looks like we just didn't hit the edge case. We should delete the mapper from crawlerOptions when invoking nodeCrawl.

cc @scotthovestadt

EDIT: sent a proposal to fix it in Jest

thymikee · 2019-06-13T09:53:52Z

Now we hit

Error: Error watching file for changes: EMFILE
    at FSEvent.FSWatcher._handle.onchange (fs.js:1359:9)

We have at least 2 options now:

Use watchman on CI
Increase the watcher limit: “Error watching file for changes: EMFILE” when run the examples from facebook/react-native/Examples #10088 (comment)

cpojer

Let's ship this and fix the CI issue separately.

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

react-native-bot · 2019-06-13T16:05:05Z

This pull request was successfully merged by @thymikee in 6c0eccd.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: An attempt to fix CI. This PR includes changes from #25241, to be removed once synced to master ## Changelog [General] [Fix] - install watchman in e2e tests to fix CI Pull Request resolved: #25257 Differential Revision: D15804513 Pulled By: cpojer fbshipit-source-id: 33d4494ffaa340f99f1dae8764449e81e552c943

Summary: Fixing Metro validation issue. Hope that helps with fixing the CI �. ## Changelog [General] [Changed] - Bump CLI to 2.0.0-rc.2 Pull Request resolved: #25241 Differential Revision: D15803610 Pulled By: cpojer fbshipit-source-id: 22136db1583f8cf5a40afd5d8a561d98cb6de982

Summary: Fixing Metro validation issue. Hope that helps with fixing the CI �. ## Changelog [General] [Changed] - Bump CLI to 2.0.0-rc.2 Pull Request resolved: facebook#25241 Differential Revision: D15803610 Pulled By: cpojer fbshipit-source-id: 22136db1583f8cf5a40afd5d8a561d98cb6de982

Summary: An attempt to fix CI. This PR includes changes from facebook#25241, to be removed once synced to master ## Changelog [General] [Fix] - install watchman in e2e tests to fix CI Pull Request resolved: facebook#25257 Differential Revision: D15804513 Pulled By: cpojer fbshipit-source-id: 33d4494ffaa340f99f1dae8764449e81e552c943

Summary: This sync includes the following changes: - **[0cac4d54c](facebook/react@0cac4d54c )**: Double invoked effects on suspended children ([#25307](facebook/react#25307)) //<Samuel Susla>// - **[3d615fc14](facebook/react@3d615fc14 )**: Grammar. Removed doubles of the word "the". ([#25295](facebook/react#25295)) //<Victoria Graf>// - **[6e3bc8a2e](facebook/react@6e3bc8a2e )**: [DevTools] Check if Proxy exists before creating DispatcherProxy ([#25278](facebook/react#25278)) //<Tianyu Yao>// - **[e7fc04b29](facebook/react@e7fc04b29 )**: [react-dom] Reorganize react-dom internals to match react ([#25277](facebook/react#25277)) //<Josh Story>// - **[0b54e0047](facebook/react@0b54e0047 )**: Handle rejections to avoid uncaught rejections ([#25272](facebook/react#25272)) //<Sebastian Markbåge>// - **[c5d06fdc5](facebook/react@c5d06fdc5 )**: [Flight] Fix Webpack Chunk Loading ([#25271](facebook/react#25271)) //<Sebastian Markbåge>// - **[975b64464](facebook/react@975b64464 )**: [Flight] response.readRoot() -> use(response) ([#25267](facebook/react#25267)) //<Sebastian Markbåge>// - **[60fbb7b14](facebook/react@60fbb7b14 )**: [Flight] Implement FlightClient in terms of Thenable/Promises instead of throwing Promises ([#25260](facebook/react#25260)) //<Sebastian Markbåge>// - **[c91a1e03b](facebook/react@c91a1e03b )**: experimental_useEvent ([#25229](facebook/react#25229)) //<Lauren Tan>// - **[346c7d4c4](facebook/react@346c7d4c4 )**: straightford explicit types ([#25253](facebook/react#25253)) //<Jan Kassens>// - **[3401e9200](facebook/react@3401e9200 )**: useMemoCache implementation ([#25143](facebook/react#25143)) //<Joseph Savona>// - **[0556bab32](facebook/react@0556bab32 )**: [Transition Tracing] More Accurate End Time ([#25105](facebook/react#25105)) //<Luna Ruan>// - **[5fdcd23aa](facebook/react@5fdcd23aa )**: Flow: upgrade to 0.140 ([#25252](facebook/react#25252)) //<Jan Kassens>// - **[5c43c6f02](facebook/react@5c43c6f02 )**: Unwind the current workInProgress if it's suspended ([#25247](facebook/react#25247)) //<Sebastian Markbåge>// - **[e52fa4c57](facebook/react@e52fa4c57 )**: Add early exit to strict mode ([#25235](facebook/react#25235)) //<Samuel Susla>// - **[6aa38e74c](facebook/react@6aa38e74c )**: Flow: enable unsafe-addition error ([#25242](facebook/react#25242)) //<Jan Kassens>// - **[ba7b6f418](facebook/react@ba7b6f418 )**: Flow: upgrade to 0.132 ([#25244](facebook/react#25244)) //<Jan Kassens>// - **[9328988c0](facebook/react@9328988c0 )**: Flow: fix Fiber typed as any ([#25241](facebook/react#25241)) //<Jan Kassens>// - **[c739cef2f](facebook/react@c739cef2f )**: Flow: ReactFiberHotReloading recursive type ([#25225](facebook/react#25225)) //<Jan Kassens>// - **[c156ecd48](facebook/react@c156ecd48 )**: Add some test coverage for some error cases ([#25240](facebook/react#25240)) //<Sebastian Markbåge>// - **[3613284dc](facebook/react@3613284dc )**: experimental_use(context) for server components and ssr ([#25226](facebook/react#25226)) //<mofeiZ>// - **[269c4e975](facebook/react@269c4e975 )**: Prevent infinite re-renders in StrictMode + Offscreen ([#25203](facebook/react#25203)) //<Samuel Susla>// - **[8003ab9cf](facebook/react@8003ab9cf )**: Flow: remove explicit object syntax ([#25223](facebook/react#25223)) //<Jan Kassens>// - **[492c6e29e](facebook/react@492c6e29e )**: Flow: upgrade to 0.127 ([#25221](facebook/react#25221)) //<Jan Kassens>// - **[8a9e7b6ce](facebook/react@8a9e7b6ce )**: Flow: implicit-inexact-object=error ([#25210](facebook/react#25210)) //<Jan Kassens>// - **[37cc6bf12](facebook/react@37cc6bf12 )**: Remove useDeferredValue and useTransition from Flight subset ([#25215](facebook/react#25215)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions c28f313...0cac4d5 jest_e2e[run_all_tests] Reviewed By: rickhanlonii Differential Revision: D39696377 fbshipit-source-id: 113878d22d6244b8555b5fb86db1da5d43f7cfd9

Summary: This sync includes the following changes: - **[0cac4d54c](facebook/react@0cac4d54c )**: Double invoked effects on suspended children ([facebook#25307](facebook/react#25307)) //<Samuel Susla>// - **[3d615fc14](facebook/react@3d615fc14 )**: Grammar. Removed doubles of the word "the". ([facebook#25295](facebook/react#25295)) //<Victoria Graf>// - **[6e3bc8a2e](facebook/react@6e3bc8a2e )**: [DevTools] Check if Proxy exists before creating DispatcherProxy ([facebook#25278](facebook/react#25278)) //<Tianyu Yao>// - **[e7fc04b29](facebook/react@e7fc04b29 )**: [react-dom] Reorganize react-dom internals to match react ([facebook#25277](facebook/react#25277)) //<Josh Story>// - **[0b54e0047](facebook/react@0b54e0047 )**: Handle rejections to avoid uncaught rejections ([facebook#25272](facebook/react#25272)) //<Sebastian Markbåge>// - **[c5d06fdc5](facebook/react@c5d06fdc5 )**: [Flight] Fix Webpack Chunk Loading ([facebook#25271](facebook/react#25271)) //<Sebastian Markbåge>// - **[975b64464](facebook/react@975b64464 )**: [Flight] response.readRoot() -> use(response) ([facebook#25267](facebook/react#25267)) //<Sebastian Markbåge>// - **[60fbb7b14](facebook/react@60fbb7b14 )**: [Flight] Implement FlightClient in terms of Thenable/Promises instead of throwing Promises ([facebook#25260](facebook/react#25260)) //<Sebastian Markbåge>// - **[c91a1e03b](facebook/react@c91a1e03b )**: experimental_useEvent ([facebook#25229](facebook/react#25229)) //<Lauren Tan>// - **[346c7d4c4](facebook/react@346c7d4c4 )**: straightford explicit types ([facebook#25253](facebook/react#25253)) //<Jan Kassens>// - **[3401e9200](facebook/react@3401e9200 )**: useMemoCache implementation ([facebook#25143](facebook/react#25143)) //<Joseph Savona>// - **[0556bab32](facebook/react@0556bab32 )**: [Transition Tracing] More Accurate End Time ([facebook#25105](facebook/react#25105)) //<Luna Ruan>// - **[5fdcd23aa](facebook/react@5fdcd23aa )**: Flow: upgrade to 0.140 ([facebook#25252](facebook/react#25252)) //<Jan Kassens>// - **[5c43c6f02](facebook/react@5c43c6f02 )**: Unwind the current workInProgress if it's suspended ([facebook#25247](facebook/react#25247)) //<Sebastian Markbåge>// - **[e52fa4c57](facebook/react@e52fa4c57 )**: Add early exit to strict mode ([facebook#25235](facebook/react#25235)) //<Samuel Susla>// - **[6aa38e74c](facebook/react@6aa38e74c )**: Flow: enable unsafe-addition error ([facebook#25242](facebook/react#25242)) //<Jan Kassens>// - **[ba7b6f418](facebook/react@ba7b6f418 )**: Flow: upgrade to 0.132 ([facebook#25244](facebook/react#25244)) //<Jan Kassens>// - **[9328988c0](facebook/react@9328988c0 )**: Flow: fix Fiber typed as any ([facebook#25241](facebook/react#25241)) //<Jan Kassens>// - **[c739cef2f](facebook/react@c739cef2f )**: Flow: ReactFiberHotReloading recursive type ([facebook#25225](facebook/react#25225)) //<Jan Kassens>// - **[c156ecd48](facebook/react@c156ecd48 )**: Add some test coverage for some error cases ([facebook#25240](facebook/react#25240)) //<Sebastian Markbåge>// - **[3613284dc](facebook/react@3613284dc )**: experimental_use(context) for server components and ssr ([facebook#25226](facebook/react#25226)) //<mofeiZ>// - **[269c4e975](facebook/react@269c4e975 )**: Prevent infinite re-renders in StrictMode + Offscreen ([facebook#25203](facebook/react#25203)) //<Samuel Susla>// - **[8003ab9cf](facebook/react@8003ab9cf )**: Flow: remove explicit object syntax ([facebook#25223](facebook/react#25223)) //<Jan Kassens>// - **[492c6e29e](facebook/react@492c6e29e )**: Flow: upgrade to 0.127 ([facebook#25221](facebook/react#25221)) //<Jan Kassens>// - **[8a9e7b6ce](facebook/react@8a9e7b6ce )**: Flow: implicit-inexact-object=error ([facebook#25210](facebook/react#25210)) //<Jan Kassens>// - **[37cc6bf12](facebook/react@37cc6bf12 )**: Remove useDeferredValue and useTransition from Flight subset ([facebook#25215](facebook/react#25215)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions c28f313...0cac4d5 jest_e2e[run_all_tests] Reviewed By: rickhanlonii Differential Revision: D39696377 fbshipit-source-id: 113878d22d6244b8555b5fb86db1da5d43f7cfd9

Bump CLI to 2.0.0-rc.2

fe31421

thymikee requested review from cpojer and hramos as code owners June 12, 2019 19:27

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Jun 12, 2019

thymikee mentioned this pull request Jun 12, 2019

fix(jest-haste-map): don't throw on missing mapper in Node crawler jestjs/jest#8558

Merged

update jest-haste-map in lockfile

07163fb

cpojer approved these changes Jun 13, 2019

View reviewed changes

facebook-github-bot approved these changes Jun 13, 2019

View reviewed changes

cpojer mentioned this pull request Jun 13, 2019

[CI] Disable test_ios_e2e and test_js_e2e tests #25248

Closed

thymikee mentioned this pull request Jun 13, 2019

[Internal] [Fix] - Install watchman in e2e tests to fix CI #25257

Closed

thymikee changed the title ~~Bump CLI to 2.0.0-rc.2~~ [Internal] [Fix] - Bump CLI to 2.0.0-rc.2 Jun 13, 2019

facebook-github-bot closed this in 6c0eccd Jun 13, 2019

react-native-bot added the Merged This PR has been merged. label Jun 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Internal] [Fix] - Bump CLI to 2.0.0-rc.2 #25241

[Internal] [Fix] - Bump CLI to 2.0.0-rc.2 #25241

thymikee commented Jun 12, 2019 •

edited

Loading

pull-bot commented Jun 12, 2019 •

edited

Loading

thymikee commented Jun 12, 2019 •

edited

Loading

thymikee commented Jun 13, 2019

cpojer left a comment

facebook-github-bot left a comment

react-native-bot commented Jun 13, 2019

[Internal] [Fix] - Bump CLI to 2.0.0-rc.2 #25241

[Internal] [Fix] - Bump CLI to 2.0.0-rc.2 #25241

Conversation

thymikee commented Jun 12, 2019 • edited Loading

Summary

Changelog

Test Plan

pull-bot commented Jun 12, 2019 • edited Loading

thymikee commented Jun 12, 2019 • edited Loading

thymikee commented Jun 13, 2019

cpojer left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

react-native-bot commented Jun 13, 2019

thymikee commented Jun 12, 2019 •

edited

Loading

pull-bot commented Jun 12, 2019 •

edited

Loading

thymikee commented Jun 12, 2019 •

edited

Loading