Fix resolving assets outside of the project root #27932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in 7deeec7. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: When an asset is outside of the metro project root, it can lead to relative paths like `/assets/../../node_modules/coolpackage/image.png` as the `httpServerLocation`. This can happen for example when using yarn workspaces with hoisted node_modules. This causes issues when bundling on iOS since we use this path in the filesystem. To avoid this we replace `../` with `_` to preserve the uniqueness of the path while avoiding these kind of problematic relative paths. The same logic is used when bundling assets in the rn-cli. CLI part of this PR: react-native-community/cli#939 ## Changelog [General] [Fixed] - Fix resolving assets outside of the project root Pull Request resolved: facebook#27932 Test Plan: Tested that an asset in a hoisted node_modules package doesn't show up before this patch and does after in a release build. Differential Revision: D19690587 Pulled By: cpojer fbshipit-source-id: 8a9c68af04594ce1503a810ecf2e97ef5bfb8004
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an asset is outside of the metro project root, it can lead to relative paths like
/assets/../../node_modules/coolpackage/image.pngas thehttpServerLocation. This can happen for example when using yarn workspaces with hoisted node_modules.This causes issues when bundling on iOS since we use this path in the filesystem. To avoid this we replace
../with_to preserve the uniqueness of the path while avoiding these kind of problematic relative paths. The same logic is used when bundling assets in the rn-cli.CLI part of this PR: react-native-community/cli#939
Changelog
[General] [Fixed] - Fix resolving assets outside of the project root
Test Plan
Tested that an asset in a hoisted node_modules package doesn't show up before this patch and does after in a release build.