Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app bundle size diff not always being compared against latest commit #28368

Closed
wants to merge 1 commit into from
Closed

Fix app bundle size diff not always being compared against latest commit #28368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bots/datastore.js
View file
Open in desktop
Expand Up @@ -89,7 +89,7 @@ function getBinarySizesCollection(firestore) {
function createOrUpdateDocument(collection, sha, data) {
const stampedData = {
...data,
timestamp: Date.now(),
timestamp: firebase.firestore.Timestamp.now(),
};
const docRef = collection.doc(sha);
return docRef.update(stampedData).catch(async error => {
Expand Down
4 changes: 2 additions & 2 deletions bots/report-bundle-size.js
View file
Open in desktop
Expand Up @@ -163,7 +163,7 @@ function report(target) {
'android-jsc-x86': android_getApkSize('jsc', 'x86'),
'android-jsc-x86_64': android_getApkSize('jsc', 'x86_64'),
},
'| android | hermes | arm',
'\\| android \\| hermes \\| arm',
);
break;

Expand All @@ -174,7 +174,7 @@ function report(target) {
'RNTester/build/Build/Products/Release-iphonesimulator/RNTester.app/RNTester',
),
},
'| ios | - | universal |',
'\\| ios \\| - \\| universal \\|',
);
break;

Expand Down