-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iOS Image.getSizeWithHeaders #29338
Conversation
Base commit: 120ff7c |
Base commit: 120ff7c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Thanks for fixing this! |
This pull request was successfully merged by @PaitoAnderson in 0bcc686. When will my fix make it into a release? | Upcoming Releases |
@PeteTheHeat Thanks for merging 🇨🇦 |
Summary: Fixes facebook#28632 Image.getSizeWithHeaders() was not working as intended on iOS. ## Changelog [iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`. Pull Request resolved: facebook#29338 Test Plan: Used RNTester and an Image URL requiring a Bearer token to test. Code: <img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png"> With Bearer Token: <img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png"> Without Bearer Token: <img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png"> Reviewed By: cpojer Differential Revision: D22783037 Pulled By: PeteTheHeat fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
Summary: Fixes #28632 Image.getSizeWithHeaders() was not working as intended on iOS. ## Changelog [iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`. Pull Request resolved: #29338 Test Plan: Used RNTester and an Image URL requiring a Bearer token to test. Code: <img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png"> With Bearer Token: <img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png"> Without Bearer Token: <img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png"> Reviewed By: cpojer Differential Revision: D22783037 Pulled By: PeteTheHeat fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
Fixes #28632
Summary
Image.getSizeWithHeaders() was not working as intended on iOS.
Changelog
[iOS] [Fixed] - Fixed headers in
Image.getSizeWithHeaders
.Test Plan
Used RNTester and an Image URL requiring a Bearer token to test.
Code:
With Bearer Token:
Without Bearer Token: