Fix unsafe cast and detect resize overflow. #31106
Closed
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Base commit: 00959ff |
Base commit: 00959ff |
There was a problem hiding this comment.
@rozele has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
asklar
approved these changes
Mar 6, 2021
There was a problem hiding this comment.
@rozele has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
May 3, 2021
Summary: Recent changes to `MapBuffer` have broken the compilation on Windows. This fix is similar to this recently-merged change: #31106 Side note - this PR only addresses a build break, but doesn't address the unsafe casting semantics in `MapBuffer`, which can still cause overflows. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Fix compilation errors on Windows. Pull Request resolved: #31363 Test Plan: RN now builds in Visual Studio on Windows. Reviewed By: mdvacca Differential Revision: D28028342 Pulled By: rozele fbshipit-source-id: 77d8d4870c59b77acfc0ab2f4c3b7df40b59851d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing unsafe cast from
inttouint16_t.Also, adding code to detect multiplication overflow during buffer resize.
Changelog
[General] [Fix] - Fix unsafe cast and detect overflow in MapBuffer.
Test Plan
Code compiles in Visual Studio 2019 without the unsafe cast warning (or error depending on the configuration).