Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fork of MapBuffer.cpp #7309

Closed
rectified95 opened this issue Mar 8, 2021 · 2 comments · Fixed by #7549
Closed

Remove fork of MapBuffer.cpp #7309

rectified95 opened this issue Mar 8, 2021 · 2 comments · Fixed by #7549
Assignees
@rectified95
Labels
Code Cleanup enhancement
Milestone
0.65

Comments

@rectified95
Copy link
Contributor

Forked during recent integration to fix a build break. PR in core - facebook/react-native#31106
@rectified95 rectified95 added the bug label Mar 8, 2021
@rectified95 rectified95 self-assigned this Mar 8, 2021
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 8, 2021
@rectified95 rectified95 changed the title Remove fork of MapBudder.cpp Remove fork of MapBuffer.cpp Mar 8, 2021
@rectified95
Copy link
Contributor Author

PR merged in core - our fork is going to get removed with the next integration PR.

@rectified95 rectified95 removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 10, 2021
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Mar 10, 2021
@rectified95 rectified95 added this to the 0.65 milestone Mar 11, 2021
@rectified95 rectified95 added Code Cleanup and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) bug labels Mar 11, 2021
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Mar 12, 2021
@rectified95
Copy link
Contributor Author

Got labeled as 'invalid triage' again - marking for triage since I'm missing something

@rectified95 rectified95 added Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Mar 16, 2021
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Mar 18, 2021
@rectified95 rectified95 mentioned this issue Apr 8, 2021
Merged
@ghost ghost closed this as completed in #7549 Apr 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rectified95 rectified95

Labels
Code Cleanup enhancement
Projects
None yet
Milestone
0.65
Development

Successfully merging a pull request may close this issue.

Integrate 3/18 nightly RN build. rectified95/react-native-windows
2 participants
@rectified95 @chrisglein