Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_windows by specifying a cwd #33861

Closed
wants to merge 1 commit into from
Closed

Conversation

cortinico
Copy link
Contributor

Summary

test_windows is currently broken due to a Jest test trying to resolve a path. On Windows we need to set the .cwd before any path can be resolved. This is an attempt to fix it (I wasn't able to verify it locally, will rely on CI).

Changelog

[Internal] - Fix test_windows by specifying a cwd

Test Plan

Test with yarn test on Mac and is green. Will wait for a CI result for windows.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 18, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,782,991 +8
android hermes armeabi-v7a 7,186,487 +1
android hermes x86 8,094,642 +4
android hermes x86_64 8,072,078 +7
android jsc arm64-v8a 9,655,594 +12
android jsc armeabi-v7a 8,427,857 +12
android jsc x86 9,607,838 +6
android jsc x86_64 10,202,471 +18

Base commit: a4690d0
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a4690d0
Branch: main

@cortinico cortinico closed this May 19, 2022
@cortinico cortinico deleted the nc/fix-windows-test branch June 27, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants