-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix downloading prebuilt hermes from the Github release #33935
Conversation
cc @hramos @cipolleschi for visibility |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: f4123b0 |
Base commit: f4123b0 |
This pull request was successfully merged by @fortmarek in 91452fc. When will my fix make it into a release? | Upcoming Releases |
Summary: This: ```ruby source[:http] = `https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz` ``` currently fails with the following error: ``` [!] Failed to load 'hermes-engine' podspec: [!] Invalid `hermes-engine.podspec` file: No such file or directory - https://github.com/facebook/react-native/releases/download/v0.69.0-rc.4/hermes-runtime-darwin-v0.69.0-rc.4.tar.gz. ``` For some reasons, the string with backticks is treated differently than with double quotes since this works: ```ruby source[:http] = "https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz" ``` ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] - Fix downloading prebuilt hermes from the Github release Pull Request resolved: #33935 Test Plan: - `npx react-native init RN069RC4 --version 0.69.0-rc.4` - in the created project, run `pod install` with hermes enabled - run `git init && git add . && git commit -m "Initial commit" && git remote add origin https://github.com/fortmarek/some-fake-repository` (this is necessary due to an unrelated bug in the RC4) - observe error - update `node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec` with the change from this commit - run `pod install` - 🎉 Reviewed By: dmitryrykun Differential Revision: D36775047 Pulled By: cortinico fbshipit-source-id: 3772adca32fe9898cde33c187d19b7b181af3677
saw the nightly was yday and rc5's bit away, so went for the patch updating but was easy enough
before after thx again @fortmarek btw i presume these backticks remain fine
|
just for completeness
- spec.platforms = { :osx => "10.13", :ios => "11.0" }
+ spec.platforms = { :osx => "10.13", :ios => "12.4" } think we need to deprecate iOS/tvOS SDK 11.0 support, now that 12.4+ is required |
ref: reactwg/react-native-releases#21 (comment) (result of the patch above on rc4, aka rc5) |
Summary: Deprecate iOS/tvOS SDK 11.0 support now that 12.4+ is required Context: #33935 (comment) ## Changelog [iOS] [Fixed] - Deprecate iOS/tvOS SDK 11.0 support now that 12.4+ is required Pull Request resolved: #33939 Reviewed By: hramos Differential Revision: D36780553 Pulled By: cortinico fbshipit-source-id: 64dd12742d1f9f949a89306dd3353ea24a31983d
Summary
This:
currently fails with the following error:
For some reasons, the string with backticks is treated differently than with double quotes since this works:
Changelog
[Internal] - Fix downloading prebuilt hermes from the Github release
Test Plan
npx react-native init RN069RC4 --version 0.69.0-rc.4
pod install
with hermes enabledgit init && git add . && git commit -m "Initial commit" && git remote add origin https://github.com/fortmarek/some-fake-repository
(this is necessary due to an unrelated bug in the RC4)node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec
with the change from this commitpod install