fix(ios): add xcode 14 workaround (turn off signing resource bundles) for pods

[kelset]

Summary

This is inspired by the Expo workaround expo/expo@d970a9e to address an issue that cocoapods has with Xcode 14: CocoaPods/CocoaPods#11402

This wants to address this #34673 in a way that we can also cherry-pick on the 0.70 branch.

Changelog

[iOS] [Fixed] - add xcode 14 workaround (turn off signing resource bundles) for React-Core

Test Plan

Tested locally by opening RNTester via Xcode 14.0.1, and targetting my iPhone as device. After applying the patch, the error for React Core AccessibilityResources disappears.

Also, added ruby test for new patch.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 36c9716
Branch: main

[cipolleschi]

We should refactor this in the ReactNativePodsUtils file and add some tests.

[danilobuerger]

I don't like how this modifies all pods, not only the ones included by rn. We only need this for one resource bundle:

react-native/React-Core.podspec

Line 46 in 88b7b64

s.resource_bundle = { "AccessibilityResources" => ["React/AccessibilityResources/*.lproj"]}

[Kudo]

I don't like how this modifies all pods, not only the ones included by rn. We only need this for one resource bundle:

we use this strategy because we also have other resource bundles at expo 😅 please do whatever best fit for react-native templates.

[kelset]

yeah I agree that this workaround is not ideal - my current concern is that if we do it for just that specific resource bundle, developers might still hit the issue. I feel that maybe we should just add this to the template so that developers will have to "opt in" into copying this pod postinstall over in their setups understanding what this is doing.

[kelset]

also, it seems that by going for this route (of not doing the signing) you might incurr in Apple rejection along the lines of:

The binary with bundle identifier 'SOME_IDENTIFIER' at path [SOME_APP.app] contains an invalid signature. Make sure you have signed your application with a distribution certificate, not an ad hoc certificate or a development
certificate. Verify that the code signing settings in Xcode are correct at the target level (which override
any values at the project level). If you are certain your code signing settings are correct, choose 'Clean
All' in Xcode, delete the 'build' directory in the Finder, and rebuild your release target.

see more details here.

So maybe we should go another route and tell folks to go for

 installer.generated_projects.each do |project|
    project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings["DEVELOPMENT_TEAM"] = "TEAM_ID"
        end
    end
  end

instead, as suggested here? (meaning, configuring the team account to sign it all)

[danilobuerger]

I think the rejects are "unrelated" and not caused by unsigned resource bundles. We have gone through review a couple of times now with unsigned resource bundles and xcode 14. 🤷‍♂️

We could just add a new func like we did for the m1 so people can opt out more easily without removing the whole post install func call.

[cipolleschi]

What if we modify this to act only on the React-Core pod, like we did here?

Also, it would be nice to wrap this code in a function that lives in the ReactNativePodsUtils class with some tests.

@kelset, if you are busy, I can take it. Let me know what do you prefer

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,741,312	+0
android	hermes	armeabi-v7a	7,143,663	+0
android	hermes	x86	8,051,980	+0
android	hermes	x86_64	8,023,548	+0
android	jsc	arm64-v8a	9,608,592	+0
android	jsc	armeabi-v7a	8,373,913	+0
android	jsc	x86	9,556,067	+0
android	jsc	x86_64	10,148,413	+0

Base commit: 36c9716
Branch: main

[cipolleschi]

Hi @kelset! Thank you for doing this! I left some more improvements for the tests. Let me know what do you think!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @kelset in 967de03.

^{When will my fix make it into a release? | Upcoming Releases}

[taylorkline]

we should be able to remove this once CocoaPods catches up to it, see more details here CocoaPods/CocoaPods#11402

Will be fixed in CocoaPods 1.12.0: CocoaPods/CocoaPods#11402 (comment)