[iOS] Use mainBundle in RCTConvert to resolve asset paths #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @javache, @nicklockwood and @sahrens to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/505905282925767/int_phab to review. |
|
This broke some of our internal tests which were relying on assets located in the test bundle. I'm going to need to solve that before I can land this. The fix itself is correct though - we'll find another solution for the tests. |
|
Sure thing, thanks for letting me know! |
ghost
closed this
in
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Nov 9, 2015
Summary: See facebook#3888 for why this is necessary. Essentially, `[NSBundle mainBundle]` loads the file path for the target app which is the only way to reference images. cc javache nicklockwood Closes facebook#3889 Reviewed By: svcscm Differential Revision: D2615580 Pulled By: nicklockwood fb-gh-sync-id: d06ce0987dde666b06bb5a7edf609ed45f325d2c
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: See facebook#3888 for why this is necessary. Essentially, `[NSBundle mainBundle]` loads the file path for the target app which is the only way to reference images. cc javache nicklockwood Closes facebook#3889 Reviewed By: svcscm Differential Revision: D2615580 Pulled By: nicklockwood fb-gh-sync-id: d06ce0987dde666b06bb5a7edf609ed45f325d2c
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3888 for why this is necessary. Essentially,
[NSBundle mainBundle]loads the file path for the target app which is the only way to reference images.Test plan: Make sure unit tests pass!
cc @javache @nicklockwood