Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate React-RCTBlob to add_dependency #41357

Closed
wants to merge 5 commits into from
Closed

Migrate React-RCTBlob to add_dependency #41357

wants to merge 5 commits into from

Commits on Nov 8, 2023

  1. Add helper function to create header_search_path (facebook#41353) 

    Summary:

Last week I helped macOS to work with static framework.
When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one.

This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated.
See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!`

In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths.

## Changelog:
[Internal] - Add helper function to create header_search_path

Reviewed By: shwanton

Differential Revision: D51026356
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8202487 View commit details
    Browse the repository at this point in the history

  2. Add helper function to add dependencies (facebook#41354) 

    Summary:

In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths.

## Context
Last week I helped macOS to work with static framework.
When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one.

This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated.
See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!`

## Changelog:
[Internal] - Add helper function to create header_search_path

Reviewed By: shwanton

Differential Revision: D51027343
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    82e9873 View commit details
    Browse the repository at this point in the history

  3. Add add_dependency function to ract_native_pods and Migrate React-RCT… 

    …AppDelegate (facebook#41355)

Summary:

This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms.
It also migrates React-RCTAppDelegate to this new mechanism to test that it works.

## Context
Last week I helped macOS to work with static framework.
When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one.

This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated.
See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!`

## Changelog:
[Internal] - Add helper function to create header_search_path

Reviewed By: shwanton

Differential Revision: D51029484
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    016f2a9 View commit details
    Browse the repository at this point in the history

  4. Cleanup React-Core (facebook#41356) 

    Summary:

React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up.

## Context
Last week I helped macOS to work with static framework.
When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one.

This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated.
See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!`

## Changelog:
[Internal] - Add helper function to create header_search_path

Reviewed By: shwanton

Differential Revision: D51030115
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9e930a1 View commit details
    Browse the repository at this point in the history

  5. Migrate React-RCTBlob to add_dependency (facebook#41357) 

    Summary:

This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden.

## Context
Last week I helped macOS to work with static framework.
When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one.

This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated.
See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!`

## Changelog:
[Internal] - Add helper function to create header_search_path

Reviewed By: shwanton

Differential Revision: D51030365
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c02a38f View commit details
    Browse the repository at this point in the history