Make the interop-layer work with components with custom name #41376
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Nov 8, 2023
Comment on lines
106
to
110
| RCTBridgeProxy *bridgeProxy; | ||
| auto optionalBridgeProxy = contextContainer->find<std::shared_ptr<void>>("RCTBridgeProxy"); | ||
| if (optionalBridgeProxy) { | ||
| bridgeProxy = unwrapManagedObjectWeakly(optionalBridgeProxy.value()); | ||
| } |
There was a problem hiding this comment.
This must be removed. 0.72 does not have bridgeless and thus it can't leverage the RCTBridgeProxy class.
Comment on lines
89
to
91
| if (bridgeProxy != nil) { | ||
| return [[bridgeProxy moduleForName:RCTNSStringFromString(componentName) lazilyLoadIfNecessary:YES] class]; | ||
| } |
There was a problem hiding this comment.
This must be removed. 0.72 does not have bridgeless and thus it can't leverage the RCTBridgeProxy class.
Summary: This should fix #37905 (comment) When working on react-native-fast-image, we realized that the interop layer does not work for components where the exported name is different from the iOS class. To fix this, we can use the Bridge to retrieve the actual view manager, given the component name. This solution should be much more robust than making assumptions on the ViewManager name, given the ComponentName. On top of that, we realized tha the interop layer was not calling `didSetProps` after setting the props, so we are invoking that. bypass-github-export-checks [iOS][Fixed] - Add support for Components with custom names in the interop layer. Pull Request resolved: #41207 Test Plan: Tested locally on an app created in 0.72 and 0.73 in Bridge and Bridgeless mode. Reviewed By: cortinico Differential Revision: D50698172 Pulled By: cipolleschi fbshipit-source-id: 49aee905418515b0204febbbe6a67c0114f37029
fortmarek
force-pushed
the
fortmarek/interop-layer
branch
from
e40af84
to
61bd291
Compare
Base commit: 47f773e |
cipolleschi
approved these changes
Nov 8, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cherry-pick of daedbe6.
Created a PR as the commit caused merge conflicts in the 0.72-stable branch.
Changelog:
[iOS][Fixed] - Add support for Components with custom names in the interop layer.
Test Plan:
See: #41207