Update CLI to v12.1.1 #41530
Merged
Update CLI to v12.1.1 #41530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
szymonrybczak
commented
Nov 17, 2023
packages/react-native/cli.js
Outdated
| @@ -67,7 +67,7 @@ async function main() { | |||
| // Ignore errors, since it's a nice to have warning | |||
| } | |||
| } | |||
| return cli.run(); | |||
| return cli.run('react-native'); | |||
There was a problem hiding this comment.
More context: react-native-community/cli#2170
There was a problem hiding this comment.
Let's use name from package.json that way each out of tree platform will work out of the box
thymikee
reviewed
Nov 17, 2023
| @@ -67,7 +67,7 @@ async function main() { | |||
| // Ignore errors, since it's a nice to have warning | |||
| } | |||
| } | |||
| return cli.run(); | |||
| return cli.run(name); | |||
There was a problem hiding this comment.
FYI, this change is intended to reduce fork surface for out of tree platforms like tvos, visionos, macos, etc, that would like to leverage CLI's init command without modifications.
There was a problem hiding this comment.
With this change, OOT platforms will only need to adjust template files and publish a package, and init command will work.
szymonrybczak
force-pushed
the
update-cli
branch
from
56357d5
to
01f0023
Compare
Merged
2 tasks
szymonrybczak
force-pushed
the
update-cli
branch
from
01f0023
to
09c77b1
Compare
Base commit: 9b1f8a8 |
huntie
approved these changes
Nov 21, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
Summary: To unlock ~~certain OOT platform capabilities~~ seamless `init` integration for out-of-tree platforms with CLI, we need to pass the package name to it. This change landed on 0.73 branch already: #41530 Depends on #41722 ## Changelog: [INTERNAL] [ADDED] - Fix init for out-of-tree platforms by passing name to CLI Pull Request resolved: #41723 Test Plan: CI green Reviewed By: christophpurrer Differential Revision: D51979329 Pulled By: dmytrorykun fbshipit-source-id: 451f70dc42ae0667bc65cba2e77898c9eec8d9ec
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…1723) Summary: To unlock ~~certain OOT platform capabilities~~ seamless `init` integration for out-of-tree platforms with CLI, we need to pass the package name to it. This change landed on 0.73 branch already: facebook#41530 Depends on facebook#41722 ## Changelog: [INTERNAL] [ADDED] - Fix init for out-of-tree platforms by passing name to CLI Pull Request resolved: facebook#41723 Test Plan: CI green Reviewed By: christophpurrer Differential Revision: D51979329 Pulled By: dmytrorykun fbshipit-source-id: 451f70dc42ae0667bc65cba2e77898c9eec8d9ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates CLI. Also I provided
platformNameparameter torun()function when executing CLI.Changelog:
[GENERAL] [CHANGED] - Bump CLI to v12.1.1
Test Plan:
CI Green