Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init for out-of-tree platforms by passing name to CLI #41723

Closed
wants to merge 1 commit into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Nov 30, 2023

Summary:

To unlock certain OOT platform capabilities seamless init integration for out-of-tree platforms with CLI, we need to pass the package name to it. This change landed on 0.73 branch already: #41530

Depends on #41722

Changelog:

[INTERNAL] [ADDED] - Fix init for out-of-tree platforms by passing name to CLI

Test Plan:

CI green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 30, 2023
@cortinico
Copy link
Contributor

To unlock certain OOT platform capabilities for CLI

Which capabilities?

@thymikee
Copy link
Contributor Author

@cortinico seamless init integration: react-native-community/cli#2170. It'd consider it a bugfix tbh.

@thymikee thymikee changed the title Pass package name to CLI's run method Fix init for out-of-tree platforms by passing name to CLI Nov 30, 2023
@NickGerleman
Copy link
Contributor

I’m pretty sure this is going to pass “react-native” for RN Windows if we organize like this.

Don’t we already have platforms declared in React Native config to read from?

@thymikee
Copy link
Contributor Author

thymikee commented Dec 1, 2023

@NickGerleman without this change react-native is essentially hardcoded. So it shouldn't break Windows and would help other platforms (visionos, macos, tvos) adopt easier ways to init. We'd love to chat with folks from Microsoft on their valuable experiences and collaborate on a proper solution, I'll schedule something soonish.

@okwasniewski
Copy link
Contributor

@NickGerleman @thymikee RN Windows also has it's name defined in package.json we are reading from: https://github.com/microsoft/react-native-windows/blob/f19a9e7e8a40a2fb7086371b3f3a955e15a1d771/vnext/package.json#L2

But even passing react-native will keep the same behaviour as current

@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

This pull request was successfully merged by @thymikee in 547643e.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Dec 11, 2023
@facebook-github-bot
Copy link
Contributor

@dmytrorykun merged this pull request in 547643e.

@thymikee thymikee deleted the cli-name-param branch December 11, 2023 15:12
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…1723)

Summary:
To unlock ~~certain OOT platform capabilities~~ seamless `init` integration for out-of-tree platforms with CLI, we need to pass the package name to it. This change landed on 0.73 branch already: facebook#41530

Depends on facebook#41722

## Changelog:

[INTERNAL] [ADDED] - Fix init for out-of-tree platforms by passing name to CLI

Pull Request resolved: facebook#41723

Test Plan: CI green

Reviewed By: christophpurrer

Differential Revision: D51979329

Pulled By: dmytrorykun

fbshipit-source-id: 451f70dc42ae0667bc65cba2e77898c9eec8d9ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants