Remove RCTDeviceInfo notification center observers when invalidating #42005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RCTDeviceInfo NSNotificationCenter observers never get removed, even after invaliding modules.
In scenarios where the
RCTUserInterfaceStyleDidChangeNotification
notification is manually posted after invaliding a bridge, the app will crash due to the interfaceFrameDidChange function being unable to get_exportedDimensions
from the old (invalidated) bridgeChangelog:
[IOS][CHANGED] - Remove RCTDeviceInfo notification center observers when invalidating
Test Plan:
Invalidate a bridge and then post a RCTUserInterfaceStyleDidChangeNotification notification