Register RCTDeviceInfo to invalidating and cleanup observer #42396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
force-pushed
the
export-D52912604
branch
from
8e40f47
to
5ff857c
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 22, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
5ff857c
to
b1ff424
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 22, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Differential Revision: D52912604
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
b1ff424
to
329d5dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
329d5dc
to
d676c67
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
d676c67
to
e931abd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
e931abd
to
cbf5011
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
cbf5011
to
cc8c739
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
cc8c739
to
fafb1dd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
force-pushed
the
export-D52912604
branch
from
fafb1dd
to
e6c1f33
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
e6c1f33
to
76db12c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
76db12c
to
29a2732
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
…#42396) Summary: Cmmunity reported [facebook#42120](facebook#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604
cipolleschi
force-pushed
the
export-D52912604
branch
from
29a2732
to
9d15e1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52912604 |
|
This pull request has been merged in d46d80d. |
blakef
pushed a commit
that referenced
this pull request
Jan 25, 2024
Summary: Pull Request resolved: #42396 Cmmunity reported [#42120](#42120) where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating. Upon investigation, I realized that: 1. The RCTDeviceInfo module is never invalidated 2. Observers are still observing even when the Bridge is in an invalidated state and it is not back up. This change makes sure that we invalidate the `RCTDeviceInfo.mm` module and that we unregister the observers. ## Changelog: [iOS][Fixed] - Make `RCTDeviceInfo` listen to invalidate events and unregister observers while invalidating the bridge Reviewed By: RSNara Differential Revision: D52912604 fbshipit-source-id: 1727bcdef5393b1bd5a272e2143bc65456c2a389
This was referenced Feb 29, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
…o module (#43737) Summary: Previous fix brings in #42396. Seems it's a mistake to re-add observer? So let's remove it and also not `invalidate` method not be called twice. ## Changelog: [IOS] [FIXED] - Remove invalidate observer instead of re-adding observer in DeviceInfo module Pull Request resolved: #43737 Test Plan: Fix for #42120 also works. Reviewed By: javache Differential Revision: D55692219 Pulled By: cipolleschi fbshipit-source-id: dba1ddc39a9f2611fc2b84fadf8c23827891379a
cortinico
pushed a commit
that referenced
this pull request
Apr 8, 2024
…o module (#43737) Summary: Previous fix brings in #42396. Seems it's a mistake to re-add observer? So let's remove it and also not `invalidate` method not be called twice. ## Changelog: [IOS] [FIXED] - Remove invalidate observer instead of re-adding observer in DeviceInfo module Pull Request resolved: #43737 Test Plan: Fix for #42120 also works. Reviewed By: javache Differential Revision: D55692219 Pulled By: cipolleschi fbshipit-source-id: dba1ddc39a9f2611fc2b84fadf8c23827891379a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cmmunity reported #42120 where React Native was crashing if RCTDeviceInfo native module was receiving a notification while the bridge is invalidating.
Upon investigation, I realized that:
This change makes sure that we invalidate the
RCTDeviceInfo.mmmodule and that we unregister the observers.Changelog:
[iOS][Fixed] - Make
RCTDeviceInfolisten to invalidate events and unregister observers while invalidating the bridgeDifferential Revision: D52912604