Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translations for non-existent languages "fb" and "cb" #42028

Closed
wants to merge 4 commits into from

Conversation

pandaninjas
Copy link

@pandaninjas pandaninjas commented Dec 21, 2023

Summary:

This PR resolves #42024
Values directories for language codes "fb" and "cb" are added incorrectly, causing Google Play Console to reject the app due to unrecognized languages.

Changelog:

[Android] [Fixed] - Removed translations for non-existent languages "fb" and "cb", fixing bug where Google Play Console refuses to accept the AAB.

Test Plan:

Under current React Native:

npx react-native@latest init AwesomeProject
cd AwesomeProject
npx react-native build-android --mode=release

Uploading AAB to Google Play Console (recommended to create a new app for this, it can be deleted later)
image
Under this contribution:
Apply this patch to the react-native in AwesomeProject
npx react-native build-android --mode=release

@facebook-github-bot
Copy link
Contributor

Hi @pandaninjas!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,573,291 -4,032
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,947,117 -3,083
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1f89a1c
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2023
@pandaninjas pandaninjas marked this pull request as ready for review December 21, 2023 18:04
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 21, 2023
@ecreeth
Copy link
Contributor

ecreeth commented Dec 21, 2023

@cortinico

@pandaninjas pandaninjas marked this pull request as draft December 21, 2023 19:24
@pandaninjas
Copy link
Author

This PR still doesn't work because generateReleaseResValues still adds values-fb and values-cb even when the directories are deleted.

@pandaninjas pandaninjas changed the title Remove translations for languages non-existent languages "fb" and "cb" Remove translations for non-existent languages "fb" and "cb" Dec 21, 2023
@NickGerleman
Copy link
Contributor

I think a bot will go add these back if they are removed. I can change some settings so that they aren't projected into OSS though.

In the meantime, could you follow the recommendation of excluding in Gradle config?

@pandaninjas
Copy link
Author

I think a bot will go add these back if they are removed. I can change some settings so that they aren't projected into OSS though.

In the meantime, could you follow the recommendation of excluding in Gradle config?

We can't use Android Gradle Plugin's resConfigs to specifically exclude languages because resConfigs is a list of languages to be included in the result AAB.

It could be possible if we specified every single language allowed by Google Play Console.

@NickGerleman
Copy link
Contributor

We removed these from 0.73 branch.

In main branch, we now filter to the list of languages published by Google as supported for Play Store distribution.

@EricB84300
Copy link

Hi when this problem will be solve it's still present on 0.73.4

@pandaninjas
Copy link
Author

Hi when this problem will be solve it's still present on 0.73.4

Have you tried .\gradlew clean before rebuilding it with npx react-native build-android --mode=release? It should be fixed (and it was for me)

@EricB84300
Copy link

Hi when this problem will be solve it's still present on 0.73.4

Have you tried .\gradlew clean before rebuilding it with npx react-native build-android --mode=release? It should be fixed (and it was for me)

Hi
Great! Thx It for me too.
Thx for your answer @pandaninjas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
6 participants