Disable expensive checks in OSS #42306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52543696 |
Base commit: 14933ad |
Summary: Internally, we have some computationally expensive checks in Debug mode when running Fabric. However, these are not very useful in OSS and they were the cause of some issues which generated noise. With this change, we are enabling those checks only in the Meta specific builds and making sure that the OSS won't incur in that cost. ## Changelog [Internal] - Disable expensive Fabric checks when running Fabric in OSS Reviewed By: cortinico, sammy-SC Differential Revision: D52543696
cipolleschi
force-pushed
the
export-D52543696
branch
from
be04b3c
to
7577091
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52543696 |
|
This pull request has been merged in 51fd418. |
blakef
pushed a commit
that referenced
this pull request
Jan 25, 2024
Summary: Pull Request resolved: #42306 Internally, we have some computationally expensive checks in Debug mode when running Fabric. However, these are not very useful in OSS and they were the cause of some issues which generated noise. With this change, we are enabling those checks only in the Meta specific builds and making sure that the OSS won't incur in that cost. ## Changelog [Internal] - Disable expensive Fabric checks when running Fabric in OSS Reviewed By: cortinico, sammy-SC Differential Revision: D52543696 fbshipit-source-id: 697f14fd21e884f293ea7cee8ee16fff73764996
blakef
added a commit
that referenced
this pull request
Jan 25, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Internally, we have some computationally expensive checks in Debug mode when running Fabric.
However, these are not very useful in OSS and they were the cause of some issues which generated noise.
With this change, we are enabling those checks only in the Meta specific builds and making sure that the OSS won't incur in that cost.
Changelog
[Internal] - Disable expensive Fabric checks when running Fabric in OSS
Reviewed By: cortinico, sammy-SC
Differential Revision: D52543696