Fix release testing script #43130
Closed
Fix release testing script #43130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
huntie
force-pushed
the
export-D53951606
branch
from
4a355fd
to
6d7f715
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53951606 |
Base commit: 7fffe69 |
Summary: Various fixes/tweaks to the `test-e2e-local` script, impacted by recent changes, found during the release process: - Fix typo in variable name for `circleciToken` arg. - Relocate erroneously positioned `process.exit` call (a force exit around Verdaccio, which we will remove in future). - Add notice on exit around Verdaccio server not being killed successfully (to do in T179377112). - Switch from Yarn to npm for test project installation — Yarn 3 is not respecting `npmRegistryServer`, see yarnpkg/yarn#2508. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53951606
huntie
force-pushed
the
export-D53951606
branch
from
6d7f715
to
2a509c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53951606 |
|
This pull request was successfully merged by @huntie in 8c51cbe. When will my fix make it into a release? | Upcoming Releases |
|
This pull request was exported from Phabricator. Differential Revision: D53951606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Various fixes/tweaks to the
test-e2e-localscript, impacted by recent changes, found during the release process:circleciTokenarg.process.exitcall (a force exit around Verdaccio, which we will remove in future).npmRegistryServer, see Yarn doesn't use specified registry for yarn install yarnpkg/yarn#2508.Changelog: [Internal]
Differential Revision: D53951606