Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release testing script #43130

Closed
wants to merge 1 commit into from
Closed

Commits on Feb 21, 2024

  1. Fix release testing script (facebook#43130)

    Summary:
    
    Various fixes/tweaks to the `test-e2e-local` script, impacted by recent changes, found during the release process:
    
    - Fix typo in variable name for `circleciToken` arg.
    - Relocate erroneously positioned `process.exit` call (a force exit around Verdaccio, which we will remove in future).
    - Add notice on exit around Verdaccio server not being killed successfully (to do in T179377112).
    - Switch from Yarn to npm for test project installation — Yarn 3 is not respecting `npmRegistryServer`, see yarnpkg/yarn#2508.
    
    Changelog: [Internal]
    
    Reviewed By: cipolleschi
    
    Differential Revision: D53951606
    huntie authored and facebook-github-bot committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2a509c4 View commit details
    Browse the repository at this point in the history