-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementations of spans #43150
Conversation
Both methods were equivalent.
...ensuring that the string is actually non-empty.
...to `MapBuffer`.
...from `MapBuffer`.
This PR includes bits based on your feedback from:
...and give me some high-level feedback? I'm especially interested if there is any chance at all that this direction could lead to the feature being merged.
|
Base commit: 767330f |
We had an opportunity to discuss the public API of Would you find a moment to take a look at this commit...
...? It significantly changes the API and implementation of |
Hi @cubuspl42, thanks for the effort! If we want to increase the chances of landing this, I suggest to split it in smaller pieces. Ideally, we can have:
Also, due to how our systems works, we might have to land the native code some days before the JS code. |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Summary:
This is the initial implementation of "spans", the feature tracked in #42602.
Changelog:
[INTERNAL] [ADDED] - Initial implementation of spans
Test Plan: