Simplify ReactViewGroup clip to border #44646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57668976 |
Summary: We can remove most of the code for clipping children to border radius, and recalculating paths, in ReactViewGroup, and rely on the padding box path/rect already set. I will move this to something more generic up the stack so other native components can reuse this logic. Changelog: [Internal] Differential Revision: D57668976
NickGerleman
force-pushed
the
export-D57668976
branch
from
a7555a9
to
71c90d8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57668976 |
Base commit: 9dfcb9e |
|
This pull request has been merged in 4294b24. |
|
This pull request was successfully merged by @NickGerleman in 4294b24. When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been reverted by 91d12d9. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44646 We can remove most of the code for clipping children to border radius, and recalculating paths, in ReactViewGroup, and rely on the padding box path/rect already set. I will move this to something more generic up the stack so other native components can reuse this logic. Changelog: [Internal] Reviewed By: javache Differential Revision: D57668976 fbshipit-source-id: 8b8cf956dc8689827bccba5e41751b465fd85eeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can remove most of the code for clipping children to border radius, and recalculating paths, in ReactViewGroup, and rely on the padding box path/rect already set.
I will move this to something more generic up the stack so other native components can reuse this logic.
Changelog: [Internal]
Differential Revision: D57668976