Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fixes race condition of m_batchHadNativeModuleOrTurboModuleCalls #44653

Closed

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes #44649.

Changelog:

[IOS] [FIXED] - Fixes race condition of m_batchHadNativeModuleOrTurboModuleCalls

Test Plan:

Demo in #44649.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 23, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,559,076 +7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,912,787 +10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 95de14d
Branch: main

@facebook-github-bot
Copy link
Contributor

@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hakonk
Copy link
Contributor

hakonk commented May 23, 2024

Nice one! @zhongwuzw

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 23, 2024
Copy link

This pull request was successfully merged by @zhongwuzw in 3f74f69.

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot
Copy link
Contributor

@sammy-SC merged this pull request in 3f74f69.

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…ebook#44653)

Summary:
Fixes facebook#44649.

## Changelog:

[IOS] [FIXED] - Fixes race condition of m_batchHadNativeModuleOrTurboModuleCalls

Pull Request resolved: facebook#44653

Test Plan: Demo in facebook#44649.

Reviewed By: fabriziocucci

Differential Revision: D57727886

Pulled By: sammy-SC

fbshipit-source-id: 967e2d8452cc477f2225151a46e9aa27698f4506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Data race as a result of concurrent access to NativeToJsBridge::m_batchHadNativeModuleOrTurboModuleCalls
4 participants