Remove false annotation #592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thanks! This is the code that renders this element in the docs. If you can come up with a way to annotate those it would be great :) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: I'd love to add annotations letting people know that this function and a few others take `SyntheticEvent`s but that may be inconsistent with the rest of the docs. For now, this particular annotation should be removed Closes facebook#592 Github Author: Will Piers <wpiers@rallydev.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: I'd love to add annotations letting people know that this function and a few others take `SyntheticEvent`s but that may be inconsistent with the rest of the docs. For now, this particular annotation should be removed Closes facebook#592 Github Author: Will Piers <wpiers@rallydev.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
appden
added a commit
to appden/react-native
that referenced
this pull request
Sep 10, 2020
* Fix passthrough props on TouchableWithoutFeedback Most of the macOS-specific props should be passed through, but acceptsKeyboardFocus and enableFocusRing should default to true like the other Touchable components. * Update snapshots with TouchableWithoutFeedback fix
This was referenced Sep 11, 2020
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Sep 14, 2020
* Fix passthrough props on TouchableWithoutFeedback Most of the macOS-specific props should be passed through, but acceptsKeyboardFocus and enableFocusRing should default to true like the other Touchable components. * Update snapshots with TouchableWithoutFeedback fix
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to add annotations letting people know that this function and a few others take
SyntheticEvents but that may be inconsistent with the rest of the docs. For now, this particular annotation should be removed