Add support for delete animation in LayoutAnimation on Android #7171
Conversation
|
By analyzing the blame information on this pull request, we identified @ericvicenti and @mkonicek to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
janicduplessis
force-pushed
the
layout-animation-android
branch
2 times, most recently
from
5bfb4cf
to
b5cb260
Compare
|
@janicduplessis updated the pull request. |
2 similar comments
|
@janicduplessis updated the pull request. |
|
@janicduplessis updated the pull request. |
|
@ericvicenti would you mind taking a look at this pull request? It's been a while since the last commit was reviewed. |
|
@janicduplessis I just pinged @astreet and Olivier. |
| @@ -38,6 +39,8 @@ const UIExplorerNavigationReducer = require('./UIExplorerNavigationReducer'); | |||
| const UIExplorerStateTitleMap = require('./UIExplorerStateTitleMap'); | |||
| const URIActionMap = require('./URIActionMap'); | |||
|
|
|||
| UIManager.setLayoutAnimationEnabledExperimental(true); | |||
There was a problem hiding this comment.
Can we just enable this for the specific UIExplorerApp that showcases layout animations?
There was a problem hiding this comment.
I don't think so, I added a LayoutAnimation example in UIExplorer directly and I think the animation example app is still part of UIExplorer anyway.
I could also just enable/disable it when showing the LayoutAnimation example page but I don't know if it is really necessary.
|
Thanks for taking this on, looks like the right direction! I'd also like to get Oli's thoughts |
janicduplessis
force-pushed
the
layout-animation-android
branch
from
dc0fb93
to
155a4d9
Compare
|
@janicduplessis updated the pull request. |
|
@janicduplessis updated the pull request. |
janicduplessis
force-pushed
the
layout-animation-android
branch
from
d89fe35
to
60b9504
Compare
|
@janicduplessis updated the pull request. |
janicduplessis
force-pushed
the
layout-animation-android
branch
from
60b9504
to
d54fbba
Compare
|
@janicduplessis updated the pull request. |
|
@astreet Thanks for reviewing this! Addressed most of the things you pointed out. |
|
Sorry about the late review, looks great, thanks for updating! :) @facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Summary: Android follow up to #6779 **Test plan** Tested add/removing views in the UIExample explorer with and without setting a LayoutAnimation. Tested that user interation during the animation is properly disabled.  Closes facebook/react-native#7171 Differential Revision: D3352450 Pulled By: astreet fbshipit-source-id: 233efa041626eb26d99511d12a924e54a10f96cc
Summary: Android follow up to facebook#6779 **Test plan** Tested add/removing views in the UIExample explorer with and without setting a LayoutAnimation. Tested that user interation during the animation is properly disabled.  Closes facebook#7171 Differential Revision: D3352450 Pulled By: astreet fbshipit-source-id: 233efa041626eb26d99511d12a924e54a10f96cc
Summary: Android follow up to facebook#6779 **Test plan** Tested add/removing views in the UIExample explorer with and without setting a LayoutAnimation. Tested that user interation during the animation is properly disabled.  Closes facebook#7171 Differential Revision: D3352450 Pulled By: astreet fbshipit-source-id: 233efa041626eb26d99511d12a924e54a10f96cc
Android follow up to #6779
Test plan
Tested add/removing views in the UIExample explorer with and without setting a LayoutAnimation. Tested that user interation during the animation is properly disabled.