Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't block scroll when using non-touchable visible row for SwipeableRow #8537

Closed
wants to merge 1 commit into from
Closed

Don't block scroll when using non-touchable visible row for SwipeableRow #8537

wants to merge 1 commit into from

Conversation

chirag04
Copy link
Contributor

@chirag04 chirag04 commented Jul 2, 2016

motivation
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

Test Plan

<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
  • Tested that when using non-touchable for renderRow allows scrolling on list view.
  • Tested that when using touchable for renderRow allows scrolling on list view.

cc @fred2028

@ghost
Copy link

ghost commented Jul 2, 2016

By analyzing the blame information on this pull request, we identified @fred2028 and @glawson to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 2, 2016
@fred2028
Copy link
Contributor

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 11, 2016
@ghost
Copy link

ghost commented Jul 11, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 13a19a8 Jul 11, 2016
@satya164 satya164 deleted the chirag04-patch-2 branch July 11, 2016 17:56
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@chirag04 @samerce
Don't block scroll when using non-touchable visible row for SwipeableRow
9295e89 
Summary:
**motivation**
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

**Test Plan**
```
<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
```

* Tested that when using non-touchable for renderRow allows scrolling on list view.
* Tested that when using touchable for renderRow allows scrolling on list view.

cc fred2028
Closes facebook#8537

Differential Revision: D3542407

Pulled By: fred2028

fbshipit-source-id: b7ad7ff7c7dd1b717544746a85bb265414aa18f4
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@chirag04
Don't block scroll when using non-touchable visible row for SwipeableRow
70da59c 
Summary:
**motivation**
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

**Test Plan**
```
<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
```

* Tested that when using non-touchable for renderRow allows scrolling on list view.
* Tested that when using touchable for renderRow allows scrolling on list view.

cc fred2028
Closes facebook#8537

Differential Revision: D3542407

Pulled By: fred2028

fbshipit-source-id: b7ad7ff7c7dd1b717544746a85bb265414aa18f4
berrytj pushed a commit to mdcollab/react-native that referenced this pull request Dec 7, 2016
@chirag04 @berrytj
Don't block scroll when using non-touchable visible row for SwipeableRow
1388f92 
Summary:
**motivation**
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

**Test Plan**
```
<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
```

* Tested that when using non-touchable for renderRow allows scrolling on list view.
* Tested that when using touchable for renderRow allows scrolling on list view.

cc fred2028
Closes facebook#8537

Differential Revision: D3542407

Pulled By: fred2028

fbshipit-source-id: b7ad7ff7c7dd1b717544746a85bb265414aa18f4
berrytj pushed a commit to mdcollab/react-native that referenced this pull request Jan 22, 2017
@chirag04 @berrytj
Don't block scroll when using non-touchable visible row for SwipeableRow
827d18d 
Summary:
**motivation**
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

**Test Plan**
```
<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
```

* Tested that when using non-touchable for renderRow allows scrolling on list view.
* Tested that when using touchable for renderRow allows scrolling on list view.

cc fred2028
Closes facebook#8537

Differential Revision: D3542407

Pulled By: fred2028

fbshipit-source-id: b7ad7ff7c7dd1b717544746a85bb265414aa18f4
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@chirag04 @seraj-ahmad
Don't block scroll when using non-touchable visible row for SwipeableRow
22e5aef 
Summary:
**motivation**
Currently when using a non-touchable visible row for a SwipeableRow, the scroll on list view is blocked.

**Test Plan**
```
<SwipeableListView
   dataSource={dataSource}
   renderRow={() => <View style={styles.row}/>}
   renderQuickActions={() => <View style={styles.hiddenrow}/>}
/>
```

* Tested that when using non-touchable for renderRow allows scrolling on list view.
* Tested that when using touchable for renderRow allows scrolling on list view.

cc fred2028
Closes facebook/react-native#8537

Differential Revision: D3542407

Pulled By: fred2028

fbshipit-source-id: b7ad7ff7c7dd1b717544746a85bb265414aa18f4
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chirag04 @fred2028